Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening overlapping submenu on mobile triggers sub-item action #693

Open
klues opened this issue Aug 22, 2019 · 2 comments · May be fixed by #694
Open

Opening overlapping submenu on mobile triggers sub-item action #693

klues opened this issue Aug 22, 2019 · 2 comments · May be fixed by #694

Comments

@klues
Copy link

klues commented Aug 22, 2019

Steps to reproduce:

  1. go to https://swisnl.github.io/jQuery-contextMenu/demo/sub-menus.html in Chrome
  2. open Developer tools (Ctrl + Shift + I)
  3. use mobile device view (Ctrl + Shift + M)
  4. Use a quite small device, e.g. Galaxy S5
  5. Open the context menu of the demo by long tap
  6. Select "Sub-Group" by tap
  7. Alert opens -> sub-item of "Sub-Group" has been selected because it's positioned above the "Sub-Group" item and somehow the tap directly triggers the action of the overlapping element without even showing the submenu
klues added a commit to klues/jQuery-contextMenu that referenced this issue Aug 22, 2019
@klues
fixes swisnl#693
2f38823
@klues klues linked a pull request Aug 22, 2019 that will close this issue
Open
klues added a commit to asterics/AsTeRICS-Grid that referenced this issue Aug 22, 2019
@klues
updated version, fixed submenu issue, see swisnl/jQuery-contextMenu#693
e1a4308
@bbrala
Copy link
Member

bbrala commented Oct 5, 2019

Hmm, yeah that is a problem. I checked your PR and it seems you add a delay after opening. Not sure if that is the way to get that fixed.

@klues
Copy link
Author

klues commented Oct 7, 2019

Yeah, I've added a timeout of 100ms where the unintended action is ignored. For sure it's not a pretty solution, but it works. Feel free to change it to a more beautiful solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #693 klues/jQuery-contextMenu
2 participants
@klues @bbrala