Use WAMR for carton test
#195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies our CI scripts, and installation via Homebrew and on Linux. It also allows us to pin the version of WASI runtime we use for CLI test execution. Closes #177.
MaxDesiatov
added
dependencies
yonihemi
approved these changes
Dec 26, 2020
thecb4
reviewed
Jan 11, 2021
| swift build -c release | ||
| swift test -c release --enable-test-discovery | ||
| brew bundle | ||
| cd TestApp && ../.build/release/carton test | ||
| ../.build/release/carton test --environment defaultBrowser |
There was a problem hiding this comment.
This can be removed. It's included in the CI Tests now.
If we are going to build before tests it should be
swift build --build-tests --enable-test-discovery
swift test --enable-test-discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies our CI scripts, and installation via Homebrew and on Linux. It also allows us to pin the version of WASI runtime we use for CLI test execution.
Closes #177.
I'm not completely sure if this is blocked by swiftwasm/wamr-swift#2. Until that issue is resolved we'll use plain XCTest output formatting without our custom formatting and color highlighting in terminal.
Unfortunately, support for Swift 5.2 had to be dropped. WAMRSwift requires Swift 5.3 for conditional target dependencies to work.