[build.ps1] Pin Swift 6.0.0 for MSVC 14.40+ compatibility #76566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compatibility C++ STL from MSVC 14.40 and newer versions require Clang 17+ to build. Swift 5.10.1 is no longer capable, but thankfully we have 6.0 now.
stevapple
changed the title
compnerd
requested changes
Sep 19, 2024
|
@compnerd The Windows on ARM build is already using (a snapshot of) Swift 6.0. An alternative is to fix MSVC version in CI and document that anyone who wants to build a Windows toolchain either needs to provide a custom Swift 6.0 toolchain or to use MSVC 14.39-. |
etcwilde
requested changes
Sep 26, 2024
There was a problem hiding this comment.
No, we need to maintain the invariant that an older compiler can compile the current compiler. The patch for handling static_assert(false ...) for the new Windows SDK has already been backported and will be part of a future 5.10 release dot release, so we should use that once it is out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++ STL from MSVC 14.40 and newer versions require Clang 17+ to build. Swift 5.10.1 is no longer capable, but thankfully we have 6.0 now.
We also replaced the nightly toolchain used by the ARM64 build to a newer one.