Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to customize severity of Rules #879

Open
bkolb opened this issue Nov 21, 2024 · 2 comments
Open

Allow to customize severity of Rules #879

bkolb opened this issue Nov 21, 2024 · 2 comments

Comments

@bkolb
Copy link
Contributor

bkolb commented Nov 21, 2024

At the moment there is no way to way to customize the severity of a rule. There is a TODO already in the code for that, but I cannot find the associated issue.
bkolb added a commit to bkolb/swift-format that referenced this issue Nov 21, 2024
@bkolb
Allow to customize Rule severity
13fa278 
In order to customize the severity of rules, I added
the possibility to do so via the configuration files.
If no severity is specified, we use the one pre-determined
by the Rule itself.

Example:
```
{
    "ruleSeverity": {
        "AlwaysUseLowerCamelCase": "warning",
        "AmbiguousTrailingClosureOverload": "error",
    }
}
```

Issue: swiftlang#879
@bkolb bkolb mentioned this issue Nov 21, 2024
Open
@ahoppen
Copy link
Member

ahoppen commented Nov 21, 2024

Synced to Apple’s issue tracker as rdar://140346103

bkolb added a commit to bkolb/swift-format that referenced this issue Nov 21, 2024
@bkolb
Allow to customize Rule severity
0898126 
In order to customize the severity of rules, I added
the possibility to do so via the configuration files.
If no severity is specified, we use the one pre-determined
by the Rule itself.

Example:
```
{
    "ruleSeverity": {
        "AlwaysUseLowerCamelCase": "warning",
        "AmbiguousTrailingClosureOverload": "error",
    }
}
```

Issue: swiftlang#879
@allevato
Copy link
Member

#626 is a related issue; it talks about a different idea (allowing format rules to be configured to turn off the changes they would make but still emit findings), but it also discusses the idea of leveraging that configuration to do things like change the severity.

I'm inclined to leave this issue open though since the severity thing is more of an aside in that issue.

bkolb added a commit to bkolb/swift-format that referenced this issue Nov 22, 2024
@bkolb
Allow to customize Severity for formating rules
080535c 
In order to check during CI for propper formatting,
it is now also possible to specify severity for
the formating rules.

Issue: swiftlang#879
bkolb added a commit to bkolb/swift-format that referenced this issue Nov 24, 2024
@bkolb
Allow to customize Rule severity
55f1f7d 
In order to customize the severity of rules, I added
the possibility to do so via the configuration files.
If no severity is specified, we use the one pre-determined
by the Rule itself.

Example:
```
{
    "rules": {
        "AlwaysUseLowerCamelCase": "warning",
        "AmbiguousTrailingClosureOverload": "error",
        "UseLetInEveryBoundCaseVariable": "true", // use rule default
        "UseWhereClausesInForLoops": "false", // disabled
    }
}
```

In addition, one can now control how pretty-print violations
should be treated in the same way

Example:
```
{
    "rules": {
        "TrailingComma": "warning",
        "LineLength": "error",
        "Indentation": "true", // use rule default
        "TrailingWhitespace": "false", // disabled
    }
}
```

Issue: swiftlang#879
bkolb added a commit to bkolb/swift-format that referenced this issue Nov 25, 2024
@bkolb
Allow to customize Rule severity
7a2aff7 
In order to customize the severity of rules, I added
the possibility to do so via the configuration files.
If no severity is specified, we use the one pre-determined
by the Rule itself.

Example:
```
{
    "rules": {
        "AlwaysUseLowerCamelCase": "warning",
        "AmbiguousTrailingClosureOverload": "error",
        "UseLetInEveryBoundCaseVariable": "true", // use rule default
        "UseWhereClausesInForLoops": "false", // disabled
    }
}
```

In addition, one can now control how pretty-print violations
should be treated in the same way

Example:
```
{
    "rules": {
        "TrailingComma": "warning",
        "LineLength": "error",
        "Indentation": "true", // use rule default
        "TrailingWhitespace": "false", // disabled
    }
}
```

Issue: swiftlang#879
bkolb added a commit to bkolb/swift-format that referenced this issue Nov 25, 2024
@bkolb
Allow to customize Rule severity
1f8e4f0 
In order to customize the severity of rules, I added
the possibility to do so via the configuration files.
If no severity is specified, we use the one pre-determined
by the Rule itself.

Example:
```
{
    "rules": {
        "AlwaysUseLowerCamelCase": "warning",
        "AmbiguousTrailingClosureOverload": "error",
        "UseLetInEveryBoundCaseVariable": "true", // use rule default
        "UseWhereClausesInForLoops": "false", // disabled
    }
}
```

In addition, one can now control how pretty-print violations
should be treated in the same way

Example:
```
{
    "rules": {
        "TrailingComma": "warning",
        "LineLength": "error",
        "Indentation": "true", // use rule default
        "TrailingWhitespace": "false", // disabled
    }
}
```

Issue: swiftlang#879
bkolb added a commit to bkolb/swift-format that referenced this issue Nov 25, 2024
@bkolb
Allow to customize Rule severity
21693ff 
In order to customize the severity of rules, I added
the possibility to do so via the configuration files.
If no severity is specified, we use the one pre-determined
by the Rule itself.

Example:
```
{
    "rules": {
        "AlwaysUseLowerCamelCase": "warning",
        "AmbiguousTrailingClosureOverload": "error",
        "UseLetInEveryBoundCaseVariable": "true", // use rule default
        "UseWhereClausesInForLoops": "false", // disabled
    }
}
```

In addition, one can now control how pretty-print violations
should be treated in the same way

Example:
```
{
    "rules": {
        "TrailingComma": "warning",
        "LineLength": "error",
        "Indentation": "true", // use rule default
        "TrailingWhitespace": "false", // disabled
    }
}
```

Issue: swiftlang#879
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bkolb @allevato @ahoppen