Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint is inconsistent on how source paths are reported #818

Open
thomasvl opened this issue Sep 24, 2024 · 1 comment
Open

Lint is inconsistent on how source paths are reported #818

thomasvl opened this issue Sep 24, 2024 · 1 comment

Comments

@thomasvl
Copy link

  1. Checkout https://github.com/apple/swift-protobuf @ c9fbc332ed293c64ff70af8d82367ca530dce11c
  2. Run
    swift format lint \
        Sources/SwiftProtobuf/Message.swift \
        Tests/SwiftProtobufTests/Test_Extensions.swift

You get:

Sources/SwiftProtobuf/Message.swift:46:16: warning: [DontRepeatTypeInStaticProperties] remove the suffix 'Message' from the name of the variable 'protoMessageName'
/Users/thomasvl/src/github/swift-protobuf/Tests/SwiftProtobufTests/Test_Extensions.swift:97:68: warning: [EndOfLineComment] move end-of-line comment that exceeds the line length

The order of the two arguments doesn't matters, the path to Message.swift is reported as the shortened relative path and Test_Extensions.swift is always reported as a full path instead.

@ahoppen
Copy link
Member

ahoppen commented Sep 25, 2024

Synced to Apple’s issue tracker as rdar://136639896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants