Package Manager Allow Targets to Depend on Products in the Same Package #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heckj
reviewed
Dec 7, 2023
There was a problem hiding this comment.
I stumbled hard on the intro paragraph referencing the code block below and then moving on, assuming I'd read it. I think this would read a whole lot easier if the detail with the heart of the issue is after the code block illustrating the product dependency scenario.
proposals/NNNN-swiftpm-targets-same-package-product-dependencies.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joseph Heck <[email protected]>
|
Thanks for the feedback! I agree 👍 I've moved the detail after the code block now |
…lementation draft PR
rjmccall
added
the
PSG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP proposal based off the discussion in this forum thread. @tammofreese created an initial implementation a year ago which is a great way to test out the proposed changes (although it may differ from the proposal slightly, and requires updating to Swift 5.9).
Forum thread: https://forums.swift.org/t/pitch-swiftpm-allow-targets-to-depend-on-products-in-the-same-package/57717/32
WIP implementation: https://github.com/tammofreese/swift-package-manager/tree/use_internal_product_as_target_dependency_experiment