Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism Quality for Droid Storage Compartment -999999 #11

Open
cyberops2021 opened this issue Jun 9, 2023 · 4 comments
Open

Mechanism Quality for Droid Storage Compartment -999999 #11

cyberops2021 opened this issue Jun 9, 2023 · 4 comments

Comments

@cyberops2021
Copy link

I seem to have found a bug while crafting a Droid Storage Compartment. If you can point me to the function responsible for computing the Mechanism Quality, I would be happy to look into it.
image

@Hakry
Copy link
Member

Hakry commented Jun 9, 2023

All of our bug reprots are handled via Mantis Bug Tracker. This issue can be found here https://www.swgemu.com/bugs/view.php?id=8868

Attribute values default to that when one is not set from the item template, the AttributeMap puts that in as a default. For sure can look into it, would be appreciate. Push the fix to Gerrit for review

@cyberops2021
Copy link
Author

Would you mind telling me what the minimum and maximum values when experimenting are supposed to be?

@cyberops2021
Copy link
Author

I haven't fixed it yet, but I'm on to something. This schematic appears to be the only droid schematic with "usemodifier" as an experimentalSubGroup item. I also noticed this lua is missing "mechanism_quality" as an experimentalSubGroup while others had it.

@cyberops2021
Copy link
Author

I don't believe that I have sign in privileges ... but here is what I think the fix is ...

I believe this can be solved by editing
droid_storage_compartment.lua:51: experimentalSubGroupTitles = {"null", "null", "decayrate", "hitpoints", "usemodifier"},

and changing "usemodifier" to "mechanism_quality"
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants