Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node bindings for swc_html_minifier #9457

Closed
slorber opened this issue Aug 19, 2024 · 7 comments · Fixed by #9461
Closed

Node bindings for swc_html_minifier #9457

slorber opened this issue Aug 19, 2024 · 7 comments · Fixed by #9461
Assignees
Milestone

Comments

@slorber
Copy link
Contributor

slorber commented Aug 19, 2024

Describe the feature

As far as I understand, swc_html_minifier only exists as a Rust crate

It would be nice to expose it as an npm package as well so that the JS community can use it.

Babel plugin or link to the feature description

No response

Additional context

For static site generators like Docusaurus, minimizing html and inlined JS is an expensive task, for which we do no have a lot of very fast options currently.

Our current dependency is:

import {minify} from 'html-minifier-terser';

It accounts for almost half the time it takes to generate static files. We could be happy to replace it with a faster option solving a similar problem.

@kdy1 kdy1 self-assigned this Aug 19, 2024
@kdy1 kdy1 added this to the Planned milestone Aug 19, 2024
kdy1 added a commit that referenced this issue Aug 20, 2024
@kdy1 kdy1 closed this as completed in d43f1b1 Aug 20, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.7.15 Aug 20, 2024
@kdy1
Copy link
Member

kdy1 commented Aug 20, 2024

I triggered a publish action for v1.7.15

@slorber
Copy link
Contributor Author

slorber commented Aug 20, 2024

Awesome 🤟😍 that was fast, can't wait to test it!

@kdy1
Copy link
Member

kdy1 commented Aug 20, 2024

Publish action failed. I'll publish the package once it's fixed.

@kdy1 kdy1 modified the milestones: v1.7.17, Planned Aug 21, 2024
@kdy1
Copy link
Member

kdy1 commented Aug 22, 2024

@Brooooooklyn Are you still working on the CI fix?

@kdy1 kdy1 modified the milestones: Planned, v1.7.17 Aug 23, 2024
@kdy1
Copy link
Member

kdy1 commented Aug 29, 2024

I fixed CI and now @swc/html is published!

@slorber
Copy link
Contributor Author

slorber commented Aug 30, 2024

Thanks! ❤️

Now can you please publish your lightningcss-loader? 😄

@swc-bot
Copy link
Collaborator

swc-bot commented Sep 30, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

3 participants