Add support for org.freedesktop.ScreenSaver #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to work with vlc, tho it does work with playing videos on youtube (using firefox). And it doesn't look to be a vlc issue, code on their side looks correct. |
Looks like vlc is trying to call Inhibit on "/ScreenSaver" rather than "/org/freedesktop/ScreenSaver". I had previously assumed binding to the latter would be enough. From a quick search I can't find documented anywhere what paths we should be using but gnome seems to use those two paths[0] so that seems like a good bet. I'll come up with a patch to add "/ScreenSaver". |
Some programs such as vlc look to /ScreenSaver rather than /org/freedesktop/ScreenSaver for their inhibiting. This brings us in line with what gnome does.
|
Added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've patched in support for the org.freedesktop.ScreenSaver interface for my own use.
Not sure if yet another way of inhibiting idle is in-scope here but thought I'd create a PR just in case.
The feature is locked behind a
-sflag as it requires claiming ownership of the D-Bus name.Currently this requires building with systemd or elogind support, although in theory all it needs is access to D-Bus.
I haven't tested this building with elogind but don't think there is any reason to expect it to work differently to systemd here.
(As a side note, I also have a patch that detects if stderr is the systemd journal and if so omits timestamps and emits log-level markers. Let me know if there is any interest)