Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save scenario completion status #357

Closed
byorgey opened this issue Jun 4, 2022 · 3 comments · Fixed by #631
Closed

Save scenario completion status #357

byorgey opened this issue Jun 4, 2022 · 3 comments · Fixed by #631
Assignees
@xsebek
Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game. Z-User Experience This issue seeks to make the game more enjoyable to play.

Comments

@byorgey
Copy link
Member

byorgey commented Jun 4, 2022

From #296 :

Save challenge status (Not started/In progress/Finished) in XDG_WHATEVER_DIR (for browsing in the menu)

Some kind of icons could then be shown in the "New game" menu showing the status of each scenario. For now, there are just two states: completed / not completed. Once we have #50 we can also have an "in progress" status.
@byorgey byorgey added Z-User Experience This issue seeks to make the game more enjoyable to play. Z-Feature A new feature to be added to the game. C-Low Hanging Fruit Ideal issue for new contributors. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. labels Jun 4, 2022
@byorgey byorgey mentioned this issue Jun 4, 2022
Closed
4 tasks
@byorgey byorgey moved this to Todo in Alpha release Jun 4, 2022
@byorgey byorgey mentioned this issue Jun 18, 2022
Closed
2 tasks
@xsebek
Copy link
Member

xsebek commented Aug 5, 2022

@byorgey I might have some time over the weekend, shall I take a look at this or do you want to do this yourself? 🙂

@xsebek xsebek pinned this issue Aug 5, 2022
@byorgey
Copy link
Member Author

byorgey commented Aug 6, 2022

I have some code already written for this, I'll either keep working on it tomorrow or, if I don't have time, at least push what I have up to a branch so you can use it (or not).

@byorgey
Copy link
Member Author

byorgey commented Aug 7, 2022

@xsebek I pushed up what I have (not much) in the completion-status branch --- some data types to represent the status of scenarios; my plan was then to have a Map from scenario paths to status values and load and save that from a file. But I'm not going to have much time to work on this for the next little while. If you want to take a look at it, feel free to use what's there, or start over from scratch if you have a different design in mind, I truly don't care either way.

@xsebek xsebek self-assigned this Aug 7, 2022
@xsebek xsebek mentioned this issue Aug 7, 2022
Merged
@xsebek xsebek moved this from Todo to PR in Alpha release Aug 9, 2022
@mergify mergify bot closed this as completed in #631 Aug 30, 2022
mergify bot pushed a commit that referenced this issue Aug 30, 2022
@xsebek @byorgey
Save scenario completion status (#631)
68333dd 
- save the latest and best completion status for a scenario
  - scenarios are either `not started`/`in progress`/`completed` with the latter two also having time (real and in ticks)
- do not save completion status for `--cheat`ers
- show the completion status in the UI
- closes #357 

Co-authored-by: Brent Yorgey <[email protected]>
Repository owner moved this from PR to Done in Alpha release Aug 30, 2022
@xsebek xsebek unpinned this issue Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xsebek xsebek

Labels
C-Low Hanging Fruit Ideal issue for new contributors. G-Scenarios An issue having to do with scenario design, the way scenarios are described and loaded, etc. S-Nice to have The bug fix or feature would be nice but doesn't currently have much negative impact. T-UI Involves the user interface. Z-Feature A new feature to be added to the game. Z-User Experience This issue seeks to make the game more enjoyable to play.
Projects
No open projects
Alpha release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save scenario completion status swarm-game/swarm
2 participants
@byorgey @xsebek