Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API filters for sales shifts #1852

Closed
JobDoesburg opened this issue Jul 29, 2021 · 3 comments · Fixed by #1984
Closed

API filters for sales shifts #1852

JobDoesburg opened this issue Jul 29, 2021 · 3 comments · Fixed by #1984
Assignees
@se-bastiaan
Labels
api Issues related to the API app:sales Issues regarding the sales-app easy and fun Easy to solve feature Issues regarding a complete new feature priority: low Should be dealt with when nothing else remains.

Comments

@JobDoesburg
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Thadmin should be able to query shifts in multiple ways. We should have filters for this

Describe the solution you'd like

API filters

Motivation

Describe alternatives you've considered

Additional context
@JobDoesburg JobDoesburg added priority: low Should be dealt with when nothing else remains. easy and fun Easy to solve feature Issues regarding a complete new feature api Issues related to the API app:sales Issues regarding the sales-app labels Jul 29, 2021
@JobDoesburg
Copy link
Contributor Author

svthalia/thadmin#78 Is also relevant

@se-bastiaan
Copy link
Contributor

It would be nice to know what filters exactly, because I have no clue what filters we'd need

@JobDoesburg
Copy link
Contributor Author

Sorry should have elaborated on this:

  • filter on whether a shift is locked or not
  • filter on whether a shift is active or not
  • filter on start/end of a shift

@KiOui KiOui self-assigned this Oct 18, 2021
@KiOui KiOui mentioned this issue Oct 18, 2021
Merged
@se-bastiaan se-bastiaan assigned se-bastiaan and unassigned KiOui Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@se-bastiaan se-bastiaan

Labels
api Issues related to the API app:sales Issues regarding the sales-app easy and fun Easy to solve feature Issues regarding a complete new feature priority: low Should be dealt with when nothing else remains.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added filter to Shift API endpoint svthalia/concrexit
3 participants
@se-bastiaan @JobDoesburg @KiOui