Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail buttons overlapping #39

Open
tomwassenberg opened this issue Feb 21, 2019 · 3 comments
Open

Detail buttons overlapping #39

tomwassenberg opened this issue Feb 21, 2019 · 3 comments
Labels
bug Something isn't working ui User interface related

Comments

@tomwassenberg
Copy link

tomwassenberg commented Feb 21, 2019

On iOS, the buttons in a photo's detail view are overlapping. Example (from Firefox, but all iOS browsers use the same rendering engine):

GitHawk Upload by tomwassenberg

@duijf
Copy link
Contributor

duijf commented Feb 21, 2019

Thanks for reporting. This is to the use of CSS grid an having left and right buttons. This happens on all screens which are narrower than a certain font size.

How would you like to see this fixed? Options I can see:

  • Decrease font size
  • Horizontal scrolling
  • Hamburger menu (would require JS)
  • Icons only
  • Move back to album button somewhere else on the page

Something else?

@tomwassenberg
Copy link
Author

Icons only

This could work, although the icon for "back to album" isn't very clear to me.

Alternatively, the prev/next buttons are quite big, so maybe their size could be reduced a little, so there's more horizontal space for the other buttons.

@duijf
Copy link
Contributor

duijf commented Mar 7, 2019

I've hidden the report button in eb30074 temporarily since we didn't implement it anyway

@duijf duijf added ui User interface related bug Something isn't working labels Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui User interface related
Projects
None yet
Development

No branches or pull requests

2 participants