Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page titles #33

Open
duijf opened this issue Feb 21, 2019 · 1 comment
Open

Page titles #33

duijf opened this issue Feb 21, 2019 · 1 comment
Labels
ui User interface related
Milestone
Next release

Comments

@duijf
Copy link
Contributor

duijf commented Feb 21, 2019

We don't set the page titles properly. We need to set them.

Candidate pieces of info:

  • Album name
  • Photo num (instead of uuid)
  • Brand - svsticky
  • "Generated with pxl"
@tomwassenberg
Copy link

The "brand", album name and photo num should also be present in the body of the detail views.

maartenberg added a commit that referenced this issue Apr 24, 2019
@maartenberg
Set album title as <title> of album page
2f2e0b5 
Refs #33
maartenberg added a commit that referenced this issue Apr 24, 2019
@maartenberg
Set photo's <title> to {album} - {index} / {total}
7b60ec2 
It's zero-indexed

Refs #33
@duijf duijf added the ui User interface related label Apr 29, 2019
@Mstiekema Mstiekema added this to the Next release milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui User interface related
Projects
None yet
Milestone
Next release
Development

No branches or pull requests
3 participants
@duijf @tomwassenberg @Mstiekema