You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I made the decision to remove the old xml parser is favor of a new parser, here are some of the reasons.
fast-xml-parser (fmp from now), had somewhere in the past changed it's license from MIT to something different making me no longer wanted to update that library ever.
fmp than had a security issue, and people started bugging me to update it
fmp currently publishes "packaged" versions that are uploaded at different times than updates to the source. I have no clue how to check if the version that sonos-ts depends upon is the same as we can all see the source from.
My trust in fmp is mostly gone at this moment, but just upgrading would be the easiest solution, so I tried that anyway. This resulted in that it's (with the latest version) no longer able to read xml from sonos that has embedded & encoded xml inside, which is like everywhere.
New library
Support for encoded xml inside the original xml
If possible decode embedded xml to correct xml automatically
Be at least as fast, minding that sonos xml is not very big, so the improvements have to be at the in small xml documents.
Use an open/accepted license
I did some heavy googling and eventually found @rgrove/parse-xml and that checked enough boxes for me.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I made the decision to remove the old xml parser is favor of a new parser, here are some of the reasons.
My trust in fmp is mostly gone at this moment, but just upgrading would be the easiest solution, so I tried that anyway. This resulted in that it's (with the latest version) no longer able to read xml from sonos that has embedded & encoded xml inside, which is like everywhere.
New library
I did some heavy googling and eventually found @rgrove/parse-xml and that checked enough boxes for me.
Beta Was this translation helpful? Give feedback.
All reactions