Added support for .NET 8 #1137
Added support for .NET 8 #1137
Conversation
- Updated test and sample projects to supports .NET 8 - Fixed compile warnings and errors including CS8352, CA1416 - Initial update to the tests workflow (runtests.yml) - Removed previously deleted items from the solution file.
- Added .NET 3.1 - Removed include-prerelease: false - Upgraded actions/cache to v4 (from v1)
- Run tests in release mode (as the benchmark) - Upgraded the actions/checkout (v2 to v4)
- nuget restore is currently the longest running work on the workflow. - initial attempt to improve it
There was a problem hiding this comment.
Thanks - this looks good to me, though release notes (especially related to the API change) are missing. I think the API change will not have a large impact and is ok, though would like to hear another opinion (@H1Gdev ?).
| steps: | ||
| - name: Checkout source | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
We could configure the dependabot to take care of these, similar to this one.
There was a problem hiding this comment.
For actions we only need to specify the major version change, so I think the dependabot might not be needed.
There was a problem hiding this comment.
Not needed, but helpful... otherwise you have to manually follow these version changes (this was just an observation, not related to this PR).
There was a problem hiding this comment.
Please, the idea is good and it is a useful service.
Just evaluating how useful it will be in this case since all minor and patch/revision are automatically picked up.
Maybe a monthly or quarterly time span might be useful - will look into it when we add release workflow.
Bump the release version to 3.5.0 (from 3.4.6), and anyone upgrading would understand. |
Sure, but it shall appear in the release notes nevertheless. |
| <Configurations>Debug;Release</Configurations> | ||
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' "> |
There was a problem hiding this comment.
Is it difficult to avoid it with implementation??
There was a problem hiding this comment.
Please can you elaborate? Cannot understand what you meant.
There was a problem hiding this comment.
Is there a way to avoid CS0618 ?
There was a problem hiding this comment.
Is there a way to avoid CS0618 ?
Maybe stop marking codes as obsolete. Better still, state the version by which such will be removed,
and then remove the obsolete codes and tests accordingly.
On the library side (SVG-NET), we do not need the warnings.
The end-user needs the warning and should care.
There was a problem hiding this comment.
In that case, is this <NoWarn> unnecessary ??
There was a problem hiding this comment.
The warning was showing up in the workflow tests, so I turned it off in the projects.
There was a problem hiding this comment.
I don't know how many warnings will show, but should we hide them ?
I think this is information that developers should know.
There was a problem hiding this comment.
Having moved the tests to Release configuration, we can release the warning in the Debug mode.
Knowing is not sufficient, there must be a plan and documentation of obsolete codes.
… Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Added support for .NET 8 - Updated test and sample projects to supports .NET 8 - Fixed compile warnings and errors including CS8352, CA1416 - Initial update to the tests workflow (runtests.yml) - Removed previously deleted items from the solution file. CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Fixing workflow errors and warnings - Added .NET 3.1 - Removed include-prerelease: false - Upgraded actions/cache to v4 (from v1) CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Update runtests.yml - Run tests in release mode (as the benchmark) - Upgraded the actions/checkout (v2 to v4) CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Add test solutions to reduce unnecessary nuget package restore - nuget restore is currently the longest running work on the workflow. - initial attempt to improve it CONTRIBUTING.md Generators README.md Samples Source Svg.Custom Tests doc docfx.json index.md license.txt Removed CS0618 in debug mode, updated release notes.
Description
runtests.yml)Type of change
CS8352compiler error requires breaking changes toCoordinateParser(StringParseris internal)runtest.yml, includesactions/checkoutversion v2 to v4actions/cacheversion v1 to v4actions/setup-dotnetversions v3 to v4NUnit.ConsoleRunnerversion 3.10.0 to 3.17.0How Has This Been Tested?