Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shared library for test applications: Svg.Tests.Common #1136

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Added shared library for test applications: Svg.Tests.Common #1136

merged 1 commit into from
Jan 25, 2024

Conversation

paulushub
Copy link
Contributor

@paulushub paulushub commented Jan 24, 2024 •
edited
Loading

Description

  • Refactored the shared test codes
  • Removed Svg.Benchmark dependency on Svg.UnitTests
  • Moved Fizzler dependent codes and references to Svg.Tests.Common

Type of change

  • Test code updates, no change in main source codes (non-breaking change which fixes an issue)
  • This change does not require a documentation update
  • Resolved review issues.

How Has This Been Tested?

  • SvgW3CTestRunner is tested for each supported platform
  • Svg.UnitTests tested on command line for each supported platform
  • Svg.Benchmarks tested on command line for each supported platform, warnings are as before will be addressed later.

@paulushub
Added shared library for test application: Svg.Tests.Common
8cb24ae 
- Refactored the shared test codes
- Removed Svg.Benchmark dependency on Svg.UnitTests
@paulushub paulushub changed the title Added shared library for test application: Svg.Tests.Common Added shared library for test applications: Svg.Tests.Common Jan 24, 2024
mrbean-bremen
mrbean-bremen approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@paulushub paulushub self-assigned this Jan 25, 2024
@paulushub paulushub merged commit 030ac29 into svg-net:master Jan 25, 2024
7 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 25, 2024
Added shared library for test application: Svg.Tests.Common (#1136) -…
17cca83 
… Refactored the shared test codes - Removed Svg.Benchmark dependency on Svg.UnitTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbean-bremen mrbean-bremen mrbean-bremen approved these changes

Assignees

@paulushub paulushub

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulushub @mrbean-bremen