-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filters (e.g. Gaussian blur) do not work #43
Comments
i have never tried them... could you debug it and make a pull request? |
Currently, none of the W3C filter examples seems to work. |
I'm also affected by this issue. I'm using a matrix transform filter to sharpen parts of the image. Instead, the whole image appears black. |
Yes, I didn't really look into this until now - I hoped that someone with a better understanding would have a look (like the original developers...). Maybe I will have a go at this sometime later, but this doesn't look like an easy fix. |
Yes, just by the sheer fact, that this ticket is open for years now, I can estimate, that this isn't trivial to fix. But thank you anyways for your help! |
Not sure if this is your problem, but if there are floats in your matrix, and you use a (non-English) locale where the decimal point is a comma, there has been a bug in reading the float values (fixed a few days ago). |
I guess, that this shouldn't be the case here. I've attached one example SVG for you. You can replace the linked picture with anything you like. The image should show a partially sharpened area in the lower right corner. |
Thanks, I will have a look later! |
Ok, I can see the original image, but no filter applied. |
...which is no surprise after checking the implementation: the only implemented filters are feColourMatrix, feGaussianBlur (partly), feMerge and feOffset. |
These are exactly the ones that are used in one of the example images - For reference, the following filter primitives are not implemented: |
Do you think, that it would be possible to implement |
Well, it depends on who will do the work, and what is a reasonable amount of time ;) |
Unfortunately I can't help you much. I'm horrible at maths and don't know the code at all. |
No problem, I just can't promise anything... |
Has there been any progress with this at all? It would be amazing if we could get more of the filters to work, especially the lighting filters such as |
Unfortunately, no progress here. I had abandoned the PR I intialially started, it didn't get anywhere (I actually forgot the details), and so far nobody else has tried this. |
You can try using https://github.com/wieslawsoltes/Svg.Skia NuGet: https://www.nuget.org/packages/svg.skia It's based on this library but requires SkiaSharp. |
@wieslawsoltes - is #590 still something to consider? It would be a big progress, an would also help this this kind of issues. |
@mrbean-bremen Yes, but not really possible to integrate with Svg.Skia at this point. I would still prefer splitting but preferably via partial classes, not really sure if that would work. I have some ideas, but not much time on hand. |
Thanks - good to hear that this is still an option! Time constraints are an issue most of us have... |
interesting, I will take a look, thank you! |
it doesn't look that complicated to implement these filters. maybe i'll try to mess around with it a bit... |
SvgGaussianBlur has a bunch of code for computing the gaussian blur of an image, but none of it seems to actually be called. Am I missing something? Cheers.
The text was updated successfully, but these errors were encountered: