Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support new Admin console #86

Open
2 of 5 tasks
sventorben opened this issue Jul 27, 2022 · 14 comments
Open
2 of 5 tasks

[Enhancement] Support new Admin console #86

sventorben opened this issue Jul 27, 2022 · 14 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request new_admin_console Issue is related to the new admin console

Comments

@sventorben
Copy link
Owner

sventorben commented Jul 27, 2022

Is there an existing feature request for this?

  • I have searched the existing issues

Is your feature related to a problem? Please describe.

With Keycloak 19 the new admin console became the default and the old one got deprecated.

Describe the solution you'd like

  • Remove the current theme used to show configured email addresses
  • Add a theme to configure email addresses via the new admin console
  • Update readme accordingly
  • Update screenshots

Describe alternatives you've considered

No response

Anything else?

No response

@sventorben sventorben self-assigned this Jul 27, 2022
@sventorben sventorben added documentation Improvements or additions to documentation enhancement New feature or request keycloak.x Relates to Keycloak.X labels Jul 27, 2022
@sventorben sventorben changed the title [Enhancement] New Admin console [Enhancement] Support new Admin console Jul 27, 2022
@sventorben
Copy link
Owner Author

see also keycloak/keycloak#13598 (comment)

@sventorben
Copy link
Owner Author

I will not work on this before the new admin console has some kind of extension mechanism that can be leveraged.

@sventorben sventorben added new_admin_console Issue is related to the new admin console and removed keycloak.x Relates to Keycloak.X labels Sep 13, 2022
@ymakiev-sc
Copy link

Hello. After spending one day without any success I decided to ask. Could you please clarify is it compatible with keycloak 18.0.0?
I've tried to apply it, but it doesn't work for some reason. Docker image is "quay.io/keycloak/keycloak:18.0.0".
Also were added start commands like --spi-theme-cache-themes=false --spi-theme-cache-templates=false but it doesn't help.
I can see this custom theme in realm settings, but when I select it nothing happen. I checked that page kc-tabs-identity-provider.html still exists in keycloak source code with the same name, but it's not replaced to custom.

Do you know what could it be?

@sventorben
Copy link
Owner Author

Hello @ymakiev-sc,

release 18.0.0 of this extension is compatible with Keycloak 18.x. All newer versions are incompatible due to some changes to internal Keycloak APIs

With regards to the theme, make sure to set the theme in the master realm and not in one of your custom realms. Please reload the page afterwards.

Best regards
Sven-Torben

@ymakiev-sc
Copy link

The cause was related to master realm as you said, because I've tried to setup it for custom realm. Thanks a lot @sventorben!

@emmarichardson
Copy link

So, we cannot set a domain on later versions? I have been unable to connect through the kcadmn.sh and the page in the console does not appear to exist...

@sventorben
Copy link
Owner Author

If you install a version of this plugin that is compatible with your Keycloak version everything should work as expected. You should be able to use the REST API or kcadm tool to set domains.

However, currently there is no way to extend the new admin console with custom tabs or editors. So, this will no longer be supported, because there is no way to implement it without forking the admin console.

sventorben added a commit that referenced this issue Feb 23, 2023
With Keycloak versions > 21 the old admin theme has been removed after
it had been deprecated since version 19.
Hence, the theme would no longer work anyways.

Please track issue #86 for updates.
@sventorben
Copy link
Owner Author

The old admin console has been removed with Keycloak version 21 (see. release notes)
I have removed the old theme from my codebase as well.

@williancolognesitrimble
Copy link

williancolognesitrimble commented Feb 24, 2023

@sventorben what can I do that make it works with keycloak 21, any workaround?
I'm facing the this error:

2023-02-24 20:18:47,400 ERROR [org.keycloak.theme.DefaultThemeManager] (executor-thread-18) Failed to find ADMIN theme keycloak, using built-in themes
2023-02-24 20:18:47,799 ERROR [org.keycloak.services.error.KeycloakErrorHandler] (executor-thread-18) Uncaught server error: java.lang.NullPointerException: Cannot invoke "org.keycloak.theme.Theme.getImportName()" because "theme" is null
	at org.keycloak.theme.DefaultThemeManager.loadTheme(DefaultThemeManager.java:119)
	at org.keycloak.theme.DefaultThemeManager.getTheme(DefaultThemeManager.java:68)
	at org.keycloak.services.resources.admin.info.ServerInfoAdminResource.setThemes(ServerInfoAdminResource.java:182)
	at org.keycloak.services.resources.admin.info.ServerInfoAdminResource.getInfo(ServerInfoAdminResource.java:103)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:170)
	at org.jboss.resteasy.core.MethodInjectorImpl.invoke(MethodInjectorImpl.java:130)
	at org.jboss.resteasy.core.ResourceMethodInvoker.internalInvokeOnTarget(ResourceMethodInvoker.java:660)
	at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTargetAfterFilter(ResourceMethodInvoker.java:524)
	at org.jboss.resteasy.core.ResourceMethodInvoker.lambda$invokeOnTarget$2(ResourceMethodInvoker.java:474)
	at org.jboss.resteasy.core.interception.jaxrs.PreMatchContainerRequestContext.filter(PreMatchContainerRequestContext.java:364)
	at org.jboss.resteasy.core.ResourceMethodInvoker.invokeOnTarget(ResourceMethodInvoker.java:476)

Edit:
I've just cloned this project and compiled the main branch, and seems like the jar I compiled is working, but the release 21.0 in github is causing the error above.

@sventorben
Copy link
Owner Author

@williancolognesitrimble can you please try version 21.0.1.
I forgot to include the removal of the old admin theme with the previous release.

@fzoske
Copy link

fzoske commented Feb 25, 2023

@sventorben I can confirm, that the error is gone with 21.0.1

@sventorben
Copy link
Owner Author

sventorben commented Mar 1, 2023

For reference: keycloak/keycloak#17313

@sventorben
Copy link
Owner Author

For reference: keycloak/keycloak#19969

@sventorben
Copy link
Owner Author

For reference: keycloak/keycloak#24805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request new_admin_console Issue is related to the new admin console
Projects
None yet
Development

No branches or pull requests

5 participants