Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Svelte 5.0 Preview #193

Open
casillasenrique opened this issue Apr 1, 2024 · 5 comments
Open

Support for Svelte 5.0 Preview #193

casillasenrique opened this issue Apr 1, 2024 · 5 comments
Labels
committed This issue has been added to the roadmap

Comments

@casillasenrique
Copy link

Describe the bug
SvelteKit app is not detected when opening up the devtools. Tried numerous reinstalls of the Chrome devtools. Is there an expected timeline on when Svelte 5 support will be added?

image

To Reproduce

  1. Create a SvelteKit app with the Svelte 5 (npm install svelte@next)
  2. Run the app locally (npm run dev)
  3. Open browser dev tools and open Svelte dev tools
  4. See error

Expected behavior
Normal behavior, Svelte app should be detected

Environment

  • Chrome version 123.0.6312.86 (Official Build) (64-bit)
  • Devtools version 2.2.0 (Installed from Chrome web store)
  • Svelte version 5.0.0-next.72

Additional context
None

@ignatiusmb
Copy link
Member

It's on the radar, we're trying to stabilize Svelte 5 first before we do any work on the integration

@ignatiusmb ignatiusmb changed the title Devtools not working with Svelte 5.0 Preview Support for Svelte 5.0 Preview Apr 2, 2024
@ignatiusmb ignatiusmb added the committed This issue has been added to the roadmap label Apr 2, 2024
@thebjorn
Copy link

Would it be possible to change the readme from

This extension officially supports Svelte 4.0 and above.

to something that mentions that 5 is not supported yet..? (I'm sure that will save people some time ;-) )

@ignatiusmb
Copy link
Member

Yep, updated the text in #212. Thanks!

@jacob-8
Copy link

jacob-8 commented Apr 28, 2024

@ignatiusmb, I love your and @RedHatter's work on the devtools! I copied it to enable Kitbook's ability to build a component tree from the current view, similar to your tool, see here. Mine's a bit simpler as at the moment as it doesn't do anything for event tracking or for watching state updates. It just takes a state snapshot whenever a component is selected.

tools3

Anyhow, seeing as how Svelte 5 components no longer dispatch SvelteRegisterBlock and SvelteRegisterComponent and don't have the create_fragment m, p, and d functions I'm going to assume your methods of tracking with Svelte components and dom elements are going to need some adjustment (using mark_module_start and mark_module_end or something). Does Svelte 5 in RC mean that these internals have stabilized? Rich is wanting us to push Svelte 5 and I'm happy to make my tool support it, but need to figure out this component and element tracking piece first. Since you're on the core team, I'm also going to assume you already have a plan for figuring out the new system.

Anyhow, all that to say that I'm available for testing whatever you come up with and will also integrate it into my tool which will hopefully give some good feedback.

@Ice-mourne
Copy link

Ice-mourne commented Sep 19, 2024

Error message in dev tools should also say svelte 5 not yet supported
To avoid people like me looking why it's not working because I didn't look closely enough into the supported versions and managed to miss "^"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
committed This issue has been added to the roadmap
Projects
None yet
Development

No branches or pull requests

5 participants