Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump peerDep to support svelte 5 #218

Open
mhkeller opened this issue May 2, 2024 · 4 comments
Open

Bump peerDep to support svelte 5 #218

mhkeller opened this issue May 2, 2024 · 4 comments

Comments

@mhkeller
Copy link

mhkeller commented May 2, 2024

I'm currently getting an npm error when I try to include this in a project that uses svelte 5 because I think npm needs to specifically be told to add beta tags: https://classic.yarnpkg.com/en/docs/dependency-versions#toc-pre-release-tags

@webJose
Copy link

webJose commented May 12, 2024

I believe I'm also in need of this.

@kling90
Copy link

kling90 commented Oct 2, 2024

Same here, Svelte 4 is installed in our packaged build environment because of the this peer dependency

image

This causes warnings at build time

image

And this error in the application

Your application, or one of its dependencies, imported from 'svelte/internal', which was a private module used by Svelte 4 components that no longer exists in Svelte 5. It is not intended to be public API. If you're a library author and you used 'svelte/internal' deliberately, please raise an issue on https://github.com/sveltejs/svelte/issues detailing your use case.

We still need support for Svelte 4 though since we still got legacy apps using the same build environment.

To move forward we added an overrides entry to package.json

{
  "overrides": {
     "svelte": "^5.0.0-next.260"
  } 
}

@benmccann
Copy link
Member

This is only an issue with the beta. The warning will go away once the final version is released

@josdejong
Copy link

josdejong commented Oct 18, 2024

It would be really helpful to me if rollup-plugin-svelte would support the current release candiates of svelte 5 too.

Is it an option to define the peerDependency similar to svelte2tsx, like the following example?

"peerDependencies": {
  "svelte": "^3.5.0 || ^4.0.0 || ^5.0.0-next.0 || ^5.0.0"
}

Or, to support future major versions too, add an entry for major release candidates: ">=3.5.0 || >=5.0.0-next.0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants