-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename 'adders' to 'extensions' #82
Comments
Adders are the things that add. Where do you see it used otherwise? Plugins doesn't feel right to me at all. Integrations is probably fine |
'Integrations' is a more neutral/less scary word than 'plugins' but there are cases where it doesn't really make sense. If I Open to a secret third option if you have any good ideas. It just can't be 'adders'. |
What we call adders are the code that's executed when you run |
Just in a grammatical sense, in Put another way: you can imagine a YouTuber saying any of these...
but not 'so now I'm going to set up the Tailwind adder'. It just sounds weird! Prior art: |
I don't think we're really disagreeing. I just noticed a couple places in #71 where it said "install adders", which I completely agree is awkward and wrong. I've updated those to remove that language. There's a header that says "Official adders" and "Community adders", which is arguably debatable, but I would be totally fine changing those to "Official integrations" and "Community integrations". There's also a bunch of places where we're talking to developers of community adders. E.g. we have a https://github.com/sveltejs/cli/tree/main/community-adder-template. I think those usages are more acceptable as we're talking about the code that's actually doing the adding. Are you okay with those or are you suggesting they should be changed as well? |
I'm suggesting we nuke 'adder' from orbit, it's not a real word. I mean it's in the dictionary but it's not, like, a word word |
Where's your sense of fun? I always thought it'd be enjoyable to be Dr. Seuss 😆 Users are probably going to be searching for "integrations", so from that standpoint it'd help with discoverability. I think "plugins" could be confusing - e.g. part of running There's tons of code references to |
We can change the code references at the same time as we get rid of all the camelCase |
Agree, I can align with integrations, plugins has a different meaning for me aswell |
One thing that I think is somewhat confusing about integrations compared to adders is that it's an overloaded term. E.g. how do we refer to these integrations vs what's listed at https://www.sveltesociety.dev/packages?category=integrations? I liked that Adder very clearly referred to a specific thing and the more I think about it the less I want to lose that. Maybe we could call these Svelte Enhancements added by running Svelte Enhancers? |
What about 'extension'? |
|
An adder is a type of snake. More generously, it's a thing that adds, not the thing being added.
'Plugins' is probably the right name, since it can cover both integrations with external libraries and things that affect the behaviour of an app without relying on libraries (like, idk, adding some logging middleware), which may become more relevant if we add plugin hooks to SvelteKit in future
The text was updated successfully, but these errors were encountered: