Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate community adder's version of @sveltejs/cli-core #55

Open
AdrianGonz97 opened this issue Oct 2, 2024 · 3 comments
Open

Validate community adder's version of @sveltejs/cli-core #55

AdrianGonz97 opened this issue Oct 2, 2024 · 3 comments

Comments

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Oct 2, 2024

We'll need to validate that the downloaded community adder is running a similar version of @svelte-cli/core as the executing instance of sv. If it fails, we'll prompt the user to update their version of sv.

For version comparisons, we can probably use https://github.com/lukeed/semiver or https://github.com/npm/node-semver

@manuel3108
Copy link
Member

Is this the same as #35 or are the titles only closely related?

@AdrianGonz97
Copy link
Member Author

AdrianGonz97 commented Oct 3, 2024

no, #35 is only about adding a warning if there's a newer version of sv available (similar to what pnpm does every time you run it)

@benmccann
Copy link
Member

I think it would be nicer if we could avoid breaking them. If we do something like #77 we probably would not need to check the version

@benmccann benmccann changed the title Validate community adder's version of @svelte-cli/core Validate community adder's version of @sveltejs/cli-core Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants