-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate community adder's version of @sveltejs/cli-core
#55
Labels
Comments
Is this the same as #35 or are the titles only closely related? |
no, #35 is only about adding a warning if there's a newer version of |
I think it would be nicer if we could avoid breaking them. If we do something like #77 we probably would not need to check the version |
benmccann
changed the title
Validate community adder's version of
Validate community adder's version of Oct 11, 2024
@svelte-cli/core
@sveltejs/cli-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We'll need to validate that the downloaded community adder is running a similar version of
@svelte-cli/core
as the executing instance ofsv
. If it fails, we'll prompt the user to update their version ofsv
.For version comparisons, we can probably use https://github.com/lukeed/semiver or https://github.com/npm/node-semver
The text was updated successfully, but these errors were encountered: