Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show output of dependency install #154

Open
benmccann opened this issue Oct 16, 2024 · 3 comments
Open

Show output of dependency install #154

benmccann opened this issue Oct 16, 2024 · 3 comments

Comments

@benmccann
Copy link
Member

Users should see any warnings about peer dependencies or other problems

@manuel3108
Copy link
Member

manuel3108 commented Oct 16, 2024

I don't necessarily agree, though i could imagine benefits.
The storybook cli for instance displays a (custom?) text of which packages will be added, but then also hides the actual output while installing the deps.

Edit: I was trying to come up with other examples, but failed to find any besides storybook that actually install the deps for you.

@AdrianGonz97
Copy link
Member

most CLIs don't run the install command for users, so that's something to consider

for those that do though, ng, astro, shadcn-ui, and create-t3-app (sorta does, but clears it upon completion) doesn't output install logs either

the only CLI I've found so far that does is nuxi

@benmccann
Copy link
Member Author

I sort of wonder if we should skip running the install as well. I feel like it annoys me just as much as it helps me. It also makes it feel like running sv takes longer than it would if we didn't do it

A lot of times I'm just creating a project as a reference of how things are done. E.g. I have an existing project that already has one of the integrations setup and I want to update it to the latest best practices by copying what the adder does. In that case the install is just wasted time

I created a poll to the ambassadors to solicit more opinions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants