Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't unset the FEED_PLUGIN_TEMPLATE_CHOICES setting without hacking the code #9

Open
ursomniac opened this issue Jul 26, 2017 · 1 comment
Labels

Comments

@ursomniac
Copy link

For whatever reason, I can't override the default template without hacking the original code.
Ideally, it SHOULD be possible to just redefine the FEED_PLUGIN_TEMPLATE_CHOICES tuple in one's own settings file.

But that doesn't appear to work.

in the settings.py file:

> from django_feedparser.settings import *
> from cmsplugin_feedparser.settings import *
> FEED_PLUGIN_TEMPLATE_CHOICES = (
>     ('feedparser_plugin/default.html', 'Kiosk Default template'),
> )

Then in the shell:

>>> from django.conf import settings
>>> settings.FEED_PLUGIN_TEMPLATE_CHOICES
(('django_feedparser/basic_feed_renderer.html', 'Default template'),)
>>> 

which is not the desired result.

@sveetch
Copy link
Owner

sveetch commented Jul 28, 2017

Pretty strange since code does not temper on settings, you may try to avoid to import cmsplugin_feedparser settings since the only one it defined is the one you want to override.

By the way you posted this issue in the wrong repository, the djangocms plugin is here : https://github.com/sveetch/cmsplugin-feedparser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants