-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run conftest on tfmigrate-plan #511
Comments
Thank you for your proposal. I understood your problem.
|
Ah, I forget about that, that's right. Can we change conftest target from |
I guess conftest can't evaluate Terraform expression (local value, input variables, functions, resource and module attributes, etc).
I'm sorry but this may be wrong.
1. tfmigrate plan's
|
Reported the issue. |
I understood why |
tfmigrate has reverted the deprecation of the tfmigrate plan --out=tfplan option. So we can fix |
Published the prerelease version v0.5.18-0. https://github.com/suzuki-shunsuke/tfaction/releases/tag/v0.5.18-0 |
Thanks for your great work! |
Hi, this is a some kind of bug report, and feature request.
I noticed that the
conftest
validation doesn't run duringtfmigrate-plan
action.We noticed that the resource definition violating our conftest policy in
terraform-plan
after tfmigrate'd.I think this part in
terraform-plan
should also be intfmigrate-plan
.tfaction/terraform-plan/main.sh
Lines 30 to 38 in 91916f7
Furthermore, there's a edge case related to this:
skip:
prefix used in tfmgirate multi-state migration.If a working directory that was added resources skipped
tfmigrate-plan
byskip:xxx
label, this would cause an issue.To fix the case, I propose splitting build matrix from [
terraform
,tfmigrate
] to [terraform
,tfmigrate
,conftest (or validation)
]. What do you think?The text was updated successfully, but these errors were encountered: