[BUG] Replay Bot Memory Leak?

[freakexeuLow]

Describe the bug
Since the 1.10 there are more crashes and at the end something about replay. When exactly all this comes is written there, I am already sleeping at this time.

Full Error Log
Link: https://pastebin.com/NBP0GgBq

Plugin List
SurfTimer 1.10
MomSurfFix 1.1.3

[freakexeuLow]

here are more crashes I already have daily, hope that Olokos fixes them :Kapp:
https://pastebin.com/765RKjTa

[olokos]

@freakexeuLow when you're reffering to me, don't hesitate to mention me just as I did.

From what I see at least part of the problem is related to momsurffix2.smx - in particular the function TryPlayerMove_Dhook.

My suggestions first up:
Update your Dhooks to the latest version
https://forums.alliedmods.net/showpost.php?p=2588686&postcount=589

Self compile and update momsurffix itself
https://github.com/GAMMACASE/MomSurfFix

See if it is still crashing, if it still does then disable momentum fix and see how it goes.
If it's still crashing after doing the updates and disabling momentum fix then do provide the logs again, without momentum fix (just to make sure it's related to surftimer itself and making the logs clearer)

It would also help if you'd tell us what's going on the server when this bug occurs, after you did the steps mentioned by me above.

[freakexeuLow]

@freakexeuLow when you're reffering to me, don't hesitate to mention me just as I did.

From what I see at least part of the problem is related to momsurffix2.smx - in particular the function TryPlayerMove_Dhook.

My suggestions first up:
Update your Dhooks to the latest version
https://forums.alliedmods.net/showpost.php?p=2588686&postcount=589

Self compile and update momsurffix itself
https://github.com/GAMMACASE/MomSurfFix

See if it is still crashing, if it still does then disable momentum fix and see how it goes.
If it's still crashing after doing the updates and disabling momentum fix then do provide the logs again, without momentum fix (just to make sure it's related to surftimer itself and making the logs clearer)

It would also help if you'd tell us what's going on the server when this bug occurs, after you did the steps mentioned by me above.

Welcome back Olokos and will you continue working on the SurfTimer or will you leave us again?

DHooks is on the last version "DHooks (2.2.0-detours15): Dynamic Hooks"
SurfMomFix: Is self compiled and I deactivated the replay bots, since then I have no more crashes

If something like this happens again, I will send the logs here

[olokos]

I didn't leave at any point, I came back to catch up with stuff and help with current issues.

If you want to do some more testing then try to disable momentum fix smx and make sure you are using latest dev code which is commit 22802eb and then enable bots again.

[Kyli3Boi]

I too have this memory leak, i think it occurs when the bots break in that infinite loop of starting and stopping within like 1 second

[olokos]

Does this bug happen all the time for you guys or after a certain time or on certain event?
I tried to generate it on my server by using latest dev code, updated all requirements and includes that needed updating and used momentum fix aswell, but doesn't seem to happen for me, but I am the only person on the server with 3 bots - map, bonus and info bot, so it might be a bit different scenario.

[freakexeuLow]

Does this bug happen all the time for you guys or after a certain time or on certain event?
I tried to generate it on my server by using latest dev code, updated all requirements and includes that needed updating and used momentum fix aswell, but doesn't seem to happen for me, but I am the only person on the server with 3 bots - map, bonus and info bot, so it might be a bit different scenario.

As I said, it's the timer. I have 3 servers with the SurfTimer, it just happens sometimes, I can't be on the server 24/7 and check it olokos and I don't think the momentum fix had anything to do with it, it worked with SurfTimer 2.8.5v without problems. So I also said, nothing more comes from you and you let Bara do everything. I think he has less experience in this area than you do, but at least he tried but I am grateful for that. I hope that you will finally fix these problems and don't leave again, it's a big project with certain problems, fluffy has already given his opinion that this doesn't make any sense anymore, so we will continue to support it as the "cksurf" already came with many problems. There are enough people who would continue to test it, but unfortunately, 0 fixes come from you and you just let your team alone. I would also write more about it, but I don't want to cause stress or anything, I'm curious if it continues or if you leave the project as it is. ;)

[olokos]

Does this bug happen all the time for you guys or after a certain time or on certain event?
I tried to generate it on my server by using latest dev code, updated all requirements and includes that needed updating and used momentum fix aswell, but doesn't seem to happen for me, but I am the only person on the server with 3 bots - map, bonus and info bot, so it might be a bit different scenario.

As I said, it's the timer. I have 3 servers with the SurfTimer, it just happens sometimes, I can't be on the server 24/7 and check it olokos and I don't think the momentum fix had anything to do with it, it worked with SurfTimer 2.8.5v without problems. So I also said, nothing more comes from you and you let Bara do everything. I think he has less experience in this area than you do, but at least he tried but I am grateful for that. I hope that you will finally fix these problems and don't leave again, it's a big project with certain problems, fluffy has already given his opinion that this doesn't make any sense anymore, so we will continue to support it as the "cksurf" already came with many problems. There are enough people who would continue to test it, but unfortunately, 0 fixes come from you and you just let your team alone. I would also write more about it, but I don't want to cause stress or anything, I'm curious if it continues or if you leave the project as it is. ;)

I'm not entirely sure why you are trying to make a scene here, I also have my own life and matters that need taking care of, but lets make some things clear.

It's not my job, but a hobby to work on surftimer.

Each time I come back to start working on surftimer, there's always somebody acting in the exact same way as you are now.

So I also said, nothing more comes from you and you let Bara do everything. I think he has less experience in this area than you do, but at least he tried but I am grateful for that.

So having more experience means that one has to work on something day and night restlessly? Nice logic.
Apart from that, I wouldn't be surprised if Bara had more experience in this than me.

There are enough people who would continue to test it
But you're not one of those people it seems as I told you EXACTLY how you should test it, but you not only ignored that, but also didn't provide new logs as requested, so all stack traces line up with current code.

I've had bots running on the server even if it's empty since my last message and there were no crashes so far, with momentum fix aswell, so I hope you can bring something valuable into this issue, apart from trying to make an unnecessary and pointless drama.

Saying

I don't want to cause stress or anything

at the end is not magically going to make the stress go away, but your behavior surely does demotivate.

I really hope you are going to bring something valuable in your next message, so we can resolve the issue, if it actually even still exists.

[freakexeuLow]

Does this bug happen all the time for you guys or after a certain time or on certain event?
I tried to generate it on my server by using latest dev code, updated all requirements and includes that needed updating and used momentum fix aswell, but doesn't seem to happen for me, but I am the only person on the server with 3 bots - map, bonus and info bot, so it might be a bit different scenario.

As I said, it's the timer. I have 3 servers with the SurfTimer, it just happens sometimes, I can't be on the server 24/7 and check it olokos and I don't think the momentum fix had anything to do with it, it worked with SurfTimer 2.8.5v without problems. So I also said, nothing more comes from you and you let Bara do everything. I think he has less experience in this area than you do, but at least he tried but I am grateful for that. I hope that you will finally fix these problems and don't leave again, it's a big project with certain problems, fluffy has already given his opinion that this doesn't make any sense anymore, so we will continue to support it as the "cksurf" already came with many problems. There are enough people who would continue to test it, but unfortunately, 0 fixes come from you and you just let your team alone. I would also write more about it, but I don't want to cause stress or anything, I'm curious if it continues or if you leave the project as it is. ;)

I'm not entirely sure why you are trying to make a scene here, I also have my own life and matters that need taking care of, but lets make some things clear.

It's not my job, but a hobby to work on surftimer.

Each time I come back to start working on surftimer, there's always somebody acting in the exact same way as you are now.

So I also said, nothing more comes from you and you let Bara do everything. I think he has less experience in this area than you do, but at least he tried but I am grateful for that.

So having more experience means that one has to work on something day and night restlessly? Nice logic.
Apart from that, I wouldn't be surprised if Bara had more experience in this than me.

There are enough people who would continue to test it
But you're not one of those people it seems as I told you EXACTLY how you should test it, but you not only ignored that, but also didn't provide new logs as requested, so all stack traces line up with current code.

I've had bots running on the server even if it's empty since my last message and there were no crashes so far, with momentum fix aswell, so I hope you can bring something valuable into this issue, apart from trying to make an unnecessary and pointless drama.

Saying

I don't want to cause stress or anything

at the end is not magically going to make the stress go away, but your behavior surely does demotivate.

I really hope you are going to bring something valuable in your next message, so we can resolve the issue, if it actually even still exists.

1. I am not forcing anybody here to continue.....You have added certain things to yourself, I have heard certain things about you and have my opinion about them. But you shouldn't leave such a project lying in the corner and don't write anything about it, you could at least have contacted us so that we could write it for certain users.

2. No, I didn't say that either, you rather let your people down, you said it was a team project where you don't stick to it and always play the ego that everything MUST be done in your name "Olokos" but the problem is already solved.

3. But you don't have any players on them, when even Kylie here reports the problem. You already know that I use the 1.10 and not 1.0.1 or 1.0.2...i can't give you more than what i have already sent here, i have disabled the replay bots and have had no problems with crashes since then. I also can't imagine that Momentum Fix has anything to do with it, other servers use it too (even on 2 bhop servers) and please don't tell me about any other plugin, it worked with 2.8.5 without any problems, also Just Sad did not have these crashes. I maintain my servers and keep them always up-to-date.

4. I also have better things to do, but I don't think it's good that you take such a project into your hands and don't get in touch and leave your team standing there alone. After all, it took you a few months to get back in touch with Discord. I don't want to start any stress, I like to help certain users. But at some point my patience is enough when the server crashes and you have to listen to all that shit and write that we are waiting on a fix from SurfTimer.

[olokos]

you said it was a team project where you don't stick to it and always play the ego that everything MUST be done in your name "Olokos"

Not sure why you're straight up lying at this point, but lets clear this one up.

• I never said that everything must be done in my name
• I never said I don't want to stick to this project being a team effort

It is solved because:

• I did accept transfer of the project from my ownership, to the team ownership - several months ago
• I renamed the repo from Surftimer-olokos to Surftimer-Official - some weeks ago
• I sent a PR renaming the project in Readme.md from olokos to Official - some weeks ago

Every member of the surftimer organization could've done this aswell, since I transferred the ownership quite some time ago now. But nobody did, maybe out of respect, maybe for some other reason, but it was me who did this.

@freakexeuLow

• I don't owe you anything
• I have never received any help or anything from you
• You are nobody to me
• This is my hobby, not a job
• You are also being unpleasant towards me on discord

If your point is that I should quit completely on this project and move on, then you're doing it right, but I am done with your nonsense.

From now on I'll ignore anything you write unless it's actually of any value to the project or its issues. As I just wasted way too much time on responding to your attacks on me.

Provide fresh logs generated with surftimer up to 22802eb commit or go away.