Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove SURFACE_MENU_ITEMS that user has no permission (UX) #23

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

remove SURFACE_MENU_ITEMS that user has no permission (UX) #23

wants to merge 2 commits into from

Conversation

fopina
Copy link
Contributor

@fopina fopina commented Feb 5, 2023 •
edited
Loading

To fix #20

Draft as tests are missing

@fopina fopina marked this pull request as draft February 5, 2023 14:40
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023 •
edited
Loading

Codecov Report

Base: 29.56% // Head: 29.18% // Decreases project coverage by -0.39% ⚠️

Coverage data is based on head (e432096) compared to base (e1fbc3c).
Patch coverage: 0.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   29.56%   29.18%   -0.39%     
==========================================
  Files           9        9              
  Lines         531      538       +7     
==========================================
  Hits          157      157              
- Misses        374      381       +7
Impacted Files Coverage Δ
theme/utils.py 14.70% <0.00%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

fopina added a commit to fopina/django-surface-theme that referenced this pull request Feb 15, 2023
@fopina
temporary to be able to pip install with bower already ran (for surfa…
edde6bf 
…ce-security#23)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty menu items
2 participants
@fopina @codecov-commenter