-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How does this compare to other libraries? #1
Comments
I did notice that if I turn on "paint flashing" in Chrome's dev tools, there are lot more (needless?) repaints with this library versus Dragula.
I wonder how this affects performance on smaller / less powerful machines. |
Thanks for the feedback 👍 |
Thanks for the info.
This works fine for my simple example, but will this work even if I use complex layout stuff inside my items? E.g. using flexbox. If no, would adding
OK I getcha. Maybe there is some needless work being done though but I could be wrong. Based on what I saw from the paint flashing, if I click down on an item in container A (and without leaving go), drag it over container B, every item in container B is re/painted, if I drag back to A, everything in A is repainted, if I drag to back to B again, everything in B is repainted again even though nothing has changed.
I won't have nested structures. At most I'll have multiple sibling lists and I want to drag between them. Is there anything beyond adding
Great. |
Confirmed that flexbox is OK. Stuff like |
Hi, am interested how it behaves with css grids? In regard that flexbox is OK. Currently am trying sortablejs, and am having weird results lol you can clearly see in the video, my guess is that css grids are the cause |
as you can see, dragging an element around, does change the html structure. |
yes it does, but its kinda not sure about where the drop area is, so sortable-chosen keeps jumping between elements, like its guessing where the drop area is in the grid, so sometimes it works sometimes it doesn't, that leads to, that if you want to drop element in big css grid area with 6 cells, works only if you drag element and drop it into top 2 or 4 cells, trying to drop element into bottom 2 cells it drops randomly onto other grid area, grid area that is just 1 cell is bigger problem in that it rarely works, keep in mind that this is using sortable js, am going to try lmdd now and report back. Regarding transitions its fine i dont need them in this case, and am using css grids because i need complex tile kinda layouts as placeholders that will display images, with flexbox i had problems with height and ratios and positioning. As you saw in the video i need every cell to fit image (whatever size it may be) full height and width, using object fit helps here also, the problem is when you add or remove element(cell) i need different layout, so for example if there are 8 images i need at least 17 different templates, then when there are 7 another 17 different templates and so on, now you can imagine using css grid areas this is sooooo nice and easy to do, not to mention maintainable and scaleble, if i need more templates just add them, and by using that kinda ascii syntax, just looking at it you can see how the layout looks like eg. So now, i need them to be draggable too lol :) so i can drag grid area "a" to grid area "f" and so on |
Ok am getting |
hi ) |
Hey, cool library. Heads up, I'll be creating a few issues :).
How does this compare to other libraries, like dragula for example, when it comes to performance / efficiency? I'm finding it hard to evaluate that (desktop & mobile).
The text was updated successfully, but these errors were encountered: