normalized input of parseStringOrThrowError method #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
suggested changes
Oct 9, 2023
rishabhpoddar
suggested changes
Oct 10, 2023
| return ((JsonObject) element).get(fieldName).getAsString(); | ||
| String s = element.get(fieldName).getAsString().trim(); | ||
|
|
||
| if (s.matches("^(?=.{1,64}@)[A-Za-z0-9_-]+(\\.[A-Za-z0-9_-]+)*@[^-][A-Za-z0-9-]+(\\.[A-Za-z0-9-]+)*(\\.[A-Za-z]{2,})$")) { |
There was a problem hiding this comment.
We use the following regex in our backend SDK: https://github.com/supertokens/supertokens-node/blob/master/lib/ts/recipe/emailpassword/utils.ts#L242.
Might want to make this consistent with that.
rishabhpoddar
suggested changes
Oct 10, 2023
| @@ -137,7 +137,12 @@ public static String parseStringOrThrowError(JsonObject element, String fieldNam | |||
| if (!stringified.contains("\"")) { | |||
| throw new Exception(); | |||
| } | |||
| return ((JsonObject) element).get(fieldName).getAsString(); | |||
There was a problem hiding this comment.
This function is called for non GET request. We might want to add the trim and toLowerCase (in case of email), to the GET request equivalent as well. The functions are getQueryParamOrThrowError and getCommaSeparatedStringArrayQueryParamOrThrowError
rishabhpoddar
merged commit e20380e
into
supertokens:email-auto-normalise
0 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
fixes #594
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any core config (similar to theaccess_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deleting the user as well ifdeleteUserIdMappingToois false.