-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: account linking #742
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: ep login issues
* fix: allow user disassociation from all tenants * fix: multitenancy * fix: updated changelog
fix: rename userId to recipeUserId
* fix: account function changes * fix: function updates
* fix: tests * fix: tests
* fix: add exp and iat to JWT payloads without scientific notation (#765) * adding dev-v6.0.9 tag to this commit to ensure building * fix: fix handling of b64 and b64url encoded access tokens (#767) * adding dev-v6.0.10 tag to this commit to ensure building * Update release.md * Update release.md * fix: ee featureflag cron job (#778) * fix: ee featureflag cron job * fix: test * fix: tests * fix: tests * adding dev-v6.0.11 tag to this commit to ensure building * fix: test (#779) * adding dev-v6.0.11 tag to this commit to ensure building * fix: test (#780) * fix: test * fix: test * adding dev-v6.0.11 tag to this commit to ensure building * fix: test (#781) * adding dev-v6.0.11 tag to this commit to ensure building * Update README.md (#783) Corrected all the grammatical errors in the README file. * fix: session concurrency issue (#785) * adding dev-v6.0.12 tag to this commit to ensure building * fix: fixing ee folder issue when empty database at startup (#786) * fix: fixing ee folder issue when empty database at startup * fix: changelog * adding dev-v6.0.12 tag to this commit to ensure building * fix: test (#787) * fix: fixing ee folder issue when empty database at startup * fix: changelog * fix: test * adding dev-v6.0.12 tag to this commit to ensure building * bug fixes * adding dev-v6.0.12 tag to this commit to ensure building * Update README.md * Update README.md * fix: stats fix (#816) * fix: stats fix * fix: pr comments * fix: disable for in mem * fix: pr comments * adding dev-v6.0.13 tag to this commit to ensure building --------- Co-authored-by: Mihály Lengyel <[email protected]> Co-authored-by: rishabhpoddar <[email protected]> Co-authored-by: Abhisar Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Base PR for account linking related changes in the core
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.json
file has been updated (if needed)pluginInterfaceSupported.json
file has been updated (if needed)build.gradle
getPaidFeatureStats
function in FeatureFlag.java filebuild.gradle
, please make sure to add themin
implementationDependencies.json
.getValidFields
inio/supertokens/config/CoreConfig.java
if new aliases were added for any core config (similar to theaccess_token_signing_key_update_interval
config alias).git tag
) in the formatvX.Y.Z
, and then find thelatest branch (
git branch --all
) whoseX.Y
is greater than the latest released tag.Remaining TODOs for this PR
all_auth_recipe_users_primary_user_id_index
andall_auth_recipe_users_primary_user_id_and_tenant_id_index
are neededgetRecipeId
from AuthRecipeUserInfo classall_auth_recipe_users
given that there already exists a fk on it, and we use this in the getUsers function.recipeId
fromgetUserInfoForRecipeIdFromUserIds
false
to isPrimary everywhere. Need to actually fetch the value from the db. You can go to UserInfo obj in all the classes and then see where the constructor is being used.fillUserInfoWithIsPrimaryUserBoolean_transaction
in the queries files anymore.Remove use ofgetPrimaryUserInfoForUserIds
in generalqueries that does not take Connection con as an arg.all_auth_recipe_users_pagination_index
andall_auth_recipe_users_primary_user_id_and_tenant_id_index
(the second one is the same, except that it's missing the time_joined_column)all_auth_recipe_users_pagination_index
has the app_id and tenant_id at the end as opposed to at the start. Does this matter?revokeAllSessionsForUser
inlinkAccounts
andunlinkAccounts
should pass in false to revoke sessions for only the recipe user idprimary_or_recipe_user_time_joined
is updated correctly during account linking and unlinkingprimary_or_recipe_user_time_joined
, index related to that and the migration scriptisVerified