From b6bfed345ecda3165cfcfe017d3a0ec4755ec8cf Mon Sep 17 00:00:00 2001 From: Bazen <49089563+bazen-teklehaymanot@users.noreply.github.com> Date: Thu, 27 Jul 2023 06:47:27 +0400 Subject: [PATCH] Updated StartConsumeFromSequence default value and validation condition --- src/Memphis.Client/Consumer/FetchMessageOptions.cs | 2 +- src/Memphis.Client/Consumer/MemphisConsumer.cs | 4 ++-- src/Memphis.Client/Consumer/MemphisConsumerOptions.cs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Memphis.Client/Consumer/FetchMessageOptions.cs b/src/Memphis.Client/Consumer/FetchMessageOptions.cs index 04f6b14..836a940 100644 --- a/src/Memphis.Client/Consumer/FetchMessageOptions.cs +++ b/src/Memphis.Client/Consumer/FetchMessageOptions.cs @@ -12,7 +12,7 @@ public sealed class FetchMessageOptions public int MaxAckTimeMs { get; set; } = 30_000; public int MaxMsgDeliveries { get; set; } = 10; public bool GenerateUniqueSuffix { get; set; } - public int StartConsumeFromSequence { get; set; } = 0; + public int StartConsumeFromSequence { get; set; } = 1; public int LastMessages { get; set; } = -1; public bool Prefetch { get; set; } } diff --git a/src/Memphis.Client/Consumer/MemphisConsumer.cs b/src/Memphis.Client/Consumer/MemphisConsumer.cs index 2b369d9..7e4e008 100644 --- a/src/Memphis.Client/Consumer/MemphisConsumer.cs +++ b/src/Memphis.Client/Consumer/MemphisConsumer.cs @@ -37,8 +37,8 @@ public sealed class MemphisConsumer : IMemphisConsumer #pragma warning disable CS8618 // Non-nullable field is uninitialized. Consider declaring as nullable. public MemphisConsumer(MemphisClient memphisClient, MemphisConsumerOptions options) { - if (options.StartConsumeFromSequence < 0) - throw new MemphisException($"Value of {nameof(options.StartConsumeFromSequence)} must be positive"); + if (options.StartConsumeFromSequence <= 0) + throw new MemphisException($"Value of {nameof(options.StartConsumeFromSequence)} must be greater than 0"); if (options.LastMessages < -1) throw new MemphisException($"Value of {nameof(options.LastMessages)} can not be less than -1"); if (options is { StartConsumeFromSequence: > 1, LastMessages: > -1 }) diff --git a/src/Memphis.Client/Consumer/MemphisConsumerOptions.cs b/src/Memphis.Client/Consumer/MemphisConsumerOptions.cs index 9c1c432..d5c5848 100644 --- a/src/Memphis.Client/Consumer/MemphisConsumerOptions.cs +++ b/src/Memphis.Client/Consumer/MemphisConsumerOptions.cs @@ -13,7 +13,7 @@ public sealed class MemphisConsumerOptions public int MaxAckTimeMs { get; set; } = 30_000; public int MaxMsgDeliveries { get; set; } = 10; public bool GenerateUniqueSuffix { get; set; } = false; - public int StartConsumeFromSequence { get; set; } = 0; + public int StartConsumeFromSequence { get; set; } = 1; public int LastMessages { get; set; } = -1; internal string RealName { get; set; }