Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please review #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PrathushaKoouri
Copy link

No description provided.

return value % self.buckets #return hash code

def bucketItemsHash(self, value):
return value % self.bucketItems # return hashcode

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value // bucketItems

Copy link

@sehaj-grover sehaj-grover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try making the changes I suggested as see if works

Comment on lines +25 to +27
if self.storage[buc] is not None and self.storage[buc][bucItem] is None:
# if main list is initialized and having a sublist and sublist hash item
# is None then initialize it to True which adds an item.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need this if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants