Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent storageKey usage. #19

Closed
activenode opened this issue Jun 19, 2024 · 3 comments
Closed

Inconsistent storageKey usage. #19

activenode opened this issue Jun 19, 2024 · 3 comments

Comments

@activenode
Copy link

Chore

Describe the chore

Currently, the only way to set the storageKey is using options.cookieOptions.name. However, for people working with both libraries, this can come confusing, although targeting the same thing in the end.

So I'm asking to have options.auth.storageKey support in this library officially.

Additional context

Current version: https://github.com/supabase/ssr/blob/main/src/createBrowserClient.ts#L147-L148

@j4w8n
Copy link
Contributor

j4w8n commented Nov 13, 2024

@activenode can you share some code that's failing to give your expected results, or provide a reproduction? I'm not having this issue with [email protected].

@j4w8n
Copy link
Contributor

j4w8n commented Nov 13, 2024

Now that I'm looking deeper, this may have been resolved in v0.4.0

@J0
Copy link
Contributor

J0 commented Nov 13, 2024

Closing as per discussion in #61, can re-open if issue persists

@J0 J0 closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants