Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve coverage of Realtime.API tests #642

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

filipecabaco
Copy link
Contributor

What kind of change does this PR introduce?

We lacked tests for one of the functions from Realtime.API. Added said coverage and refactored tests a bit

Additional context

Add any other context or screenshots.
Screenshot 2023-08-22 at 18 26 58
Screenshot 2023-08-22 at 18 25 55

We lacked tests for one of the functions from Realtime.API. Added said coverage and refactored tests a bit
@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Aug 22, 2023 5:36pm

@filipecabaco filipecabaco merged commit d5c60c3 into main Aug 22, 2023
3 checks passed
@filipecabaco filipecabaco deleted the fix/improve-api-test-coverage branch August 22, 2023 18:19
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.20.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

chasers added a commit that referenced this pull request Aug 23, 2023
* fix: Add rebalance code as an helper (#641)

* fix: Add rebalance code as an helper

Useful production code that runs ad-hoc added as an helper

---------

Co-authored-by: Stas <[email protected]>

* fix: Improve coverage of Realtime.API tests (#642)

We lacked tests for one of the functions from Realtime.API. Added said coverage and refactored tests a bit

* feat: Add broadcast endpoint (#639)

Adds a batch broadcast endpoint so users can push multiple messages into multiple topics

* fix: dont count Presence state message (#643)

* fix: dont count Presence state message

* fix: actually don't count "presence state" messages now

* feat: more Inspector opts (#644)

* feat: more inspector opts

* feat: version bump

* fix: connected

* fix: format

---------

Co-authored-by: Filipe Cabaço <[email protected]>
Co-authored-by: Stas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants