fix: Fixes flaky test on SubscriptionsCheckerTest #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for our SubscriptionChecker were flaky because of the way we checked the elements in the array.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
@filipecabaco each PR requires increasing the version in ./mix.exs |
|
🎉 This PR is included in version 2.19.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
filipecabaco
added a commit
that referenced
this pull request
Aug 21, 2023
* fix: Fixes flaky test on SubscriptionsCheckerTest (#635) Tests for our SubscriptionChecker were flaky because of the way we checked the elements in the array. * feat: Add filtering to Inspector tool (#636) * feat: Add filtering to Inspector tool Adds a filter field to the Inspector tool to set filters when creating a new connection * fix: Sets proper Realtime semver value (#637) * fix: handle null access token (#638) * fix: handle nil access token * fix: info log unexpected messages from client an clean up * fix: bump version --------- Co-authored-by: Chase Granberry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Tests for our SubscriptionChecker were flaky because of the way we checked the elements in the array.
What is the current behavior?
Flaky test due to order of lists
