fix: Metrics cleanup based on syn module #1233
Merged
+107
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
filipecabaco
force-pushed
the
fix/remove-disconnected-tenants-from-metrics
branch
from
69289d3
to
866ad44
Compare
Adds a new worker that will cleanup metrics based on our syn information to reduce the amount of data pulled by Prometheus.
filipecabaco
force-pushed
the
fix/remove-disconnected-tenants-from-metrics
branch
from
866ad44
to
17f3fdc
Compare
abc3
reviewed
Nov 22, 2024
abc3
reviewed
Nov 22, 2024
abc3
reviewed
Nov 22, 2024
Comment on lines
+44
to
+49
| tenant_ids = :ets.select(@table_name, @tenant_id_spec) | ||
|
|
||
| :ets.select(@metrics_table, @filter_spec) | ||
| |> Enum.uniq() | ||
| |> Enum.reject(fn tenant_id -> tenant_id in tenant_ids end) | ||
| |> Enum.each(fn tenant_id -> delete_metric(tenant_id) end) |
There was a problem hiding this comment.
as an alternative
Suggested change
| tenant_ids = :ets.select(@table_name, @tenant_id_spec) | |
| :ets.select(@metrics_table, @filter_spec) | |
| |> Enum.uniq() | |
| |> Enum.reject(fn tenant_id -> tenant_id in tenant_ids end) | |
| |> Enum.each(fn tenant_id -> delete_metric(tenant_id) end) | |
| :ets.foldl( | |
| fn {{_, tags}, _}, acc -> | |
| if tags[:tenant], | |
| do: delete_metric(tags[:tenant]) + acc, | |
| else: acc | |
| end, | |
| 0, | |
| @table_name | |
| ) |
There was a problem hiding this comment.
I think I prefer the simpler readability since it will be handling a low amount of data... at least for now
abc3
reviewed
Nov 22, 2024
| Deletes all metrics that contain the given tenant. | ||
| """ | ||
| @spec delete_metric(String.t()) :: :ok | ||
| def delete_metric(tenant) do |
There was a problem hiding this comment.
:ets.select_delete returns a count of deleted items, which can be useful
There was a problem hiding this comment.
yes but I was ignoring it for now as we don't have a good use case for it now
abc3
approved these changes
Nov 22, 2024
filipecabaco
deleted the
fix/remove-disconnected-tenants-from-metrics
branch
|
🎉 This PR is included in version 2.33.56 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds a new worker that will cleanup metrics based on our syn information to reduce the amount of data pulled by Prometheus.