Skip to content

Commit

Permalink
fix: Metrics cleanup based on syn module
Browse files Browse the repository at this point in the history
Adds a new worker that will cleanup metrics based on our syn information to reduce the amount of data pulled by Prometheus.
  • Loading branch information
filipecabaco committed Nov 22, 2024
1 parent da14183 commit 17f3fdc
Show file tree
Hide file tree
Showing 6 changed files with 107 additions and 38 deletions.
72 changes: 36 additions & 36 deletions README.md

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions config/runtime.exs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ config :realtime,
System.get_env("TENANT_MAX_EVENTS_PER_SECOND", "100") |> String.to_integer(),
tenant_max_joins_per_second:
System.get_env("TENANT_MAX_JOINS_PER_SECOND", "100") |> String.to_integer(),
metrics_cleaner_scheduke_timer_in_ms:
System.get_env("METRICS_CLEANER_SCHEDULE_TIMER_IN_MS", "1800000") |> String.to_integer(),
rpc_timeout: System.get_env("RPC_TIMEOUT", "30000") |> String.to_integer()

run_janitor? = System.get_env("RUN_JANITOR", "false") == "true"
Expand Down
3 changes: 2 additions & 1 deletion lib/realtime/application.ex
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ defmodule Realtime.Application do
strategy: :one_for_one,
name: Realtime.BroadcastChanges.Handler.DynamicSupervisor},
RealtimeWeb.Endpoint,
RealtimeWeb.Presence
RealtimeWeb.Presence,
Realtime.MetricsCleaner
] ++ extensions_supervisors() ++ janitor_tasks()

children =
Expand Down
60 changes: 60 additions & 0 deletions lib/realtime/metrics_cleaner.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
defmodule Realtime.MetricsCleaner do
@moduledoc false

use GenServer
require Logger

defstruct [:check_ref, :interval]

def start_link(args),
do: GenServer.start_link(__MODULE__, args, name: __MODULE__)

def init(_args) do
interval = Application.get_env(:realtime, :metrics_cleaner_scheduke_timer_in_ms)

Logger.info("Starting MetricsCleaner")
{:ok, %{check_ref: check(interval), interval: interval}}
end

def handle_info(:check, %{interval: interval} = state) do
Process.cancel_timer(state.check_ref)

{exec_time, _} = :timer.tc(fn -> loop_and_cleanup_metrics_table() end)

if exec_time > :timer.seconds(5),
do: Logger.warning("Metrics check took: #{exec_time} ms")

{:noreply, %{state | check_ref: check(interval)}}
end

def handle_info(msg, state) do
Logger.error("Unexpected message: #{inspect(msg)}")
{:noreply, state}
end

defp check(interval) do
Process.send_after(self(), :check, interval)
end

@table_name :"syn_registry_by_name_Elixir.Realtime.Tenants.Connect"
@metrics_table Realtime.PromEx.Metrics
@filter_spec [{{{:_, %{tenant: :"$1"}}, :_}, [], [:"$1"]}]
@tenant_id_spec [{{:"$1", :_, :_, :_, :_, :_}, [], [:"$1"]}]
defp loop_and_cleanup_metrics_table do
tenant_ids = :ets.select(@table_name, @tenant_id_spec)

:ets.select(@metrics_table, @filter_spec)
|> Enum.uniq()
|> Enum.reject(fn tenant_id -> tenant_id in tenant_ids end)
|> Enum.each(fn tenant_id -> delete_metric(tenant_id) end)
end

@doc """
Deletes all metrics that contain the given tenant.
"""
@spec delete_metric(String.t()) :: :ok
def delete_metric(tenant) do
:ets.select_delete(@metrics_table, [{{{:_, %{tenant: tenant}}, :_}, [], [true]}])
:ok
end
end
6 changes: 6 additions & 0 deletions lib/realtime/tenants/connect.ex
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,12 @@ defmodule Realtime.Tenants.Connect do
{:stop, :kill, state}
end

@impl true
def terminate(_, %{tenant_id: tenant_id}) do
Realtime.MetricsCleaner.delete_metric(tenant_id)
:ok
end

## Private functions

defp call_external_node(tenant_id, opts) do
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ defmodule Realtime.MixProject do
def project do
[
app: :realtime,
version: "2.33.55",
version: "2.33.56",
elixir: "~> 1.17.3",
elixirc_paths: elixirc_paths(Mix.env()),
start_permanent: Mix.env() == :prod,
Expand Down

0 comments on commit 17f3fdc

Please sign in to comment.