Add setupConnection call to custom transports #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enabling proper implementation of custom transports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling proper implementation of custom transports
What kind of change does this PR introduce?
Enables custom transports to be implemented properly - currently missing
this.setupConnection()call after initialisation, which makes the use of custom transports impossible.What is the current behavior?
Can't use custom transports without rewriting the whole RealtimeClient
What is the new behavior?
Sets up custom transports with listeners properly
Additional context
Fixes #433
We have tested it locally, and our custom transport (running in a SharedWorker) works properly now.