Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this.setupConnection() is not called for a custom transport #433

Open
2 tasks done
lauri865 opened this issue Nov 11, 2024 · 1 comment · May be fixed by #435
Open
2 tasks done

this.setupConnection() is not called for a custom transport #433

lauri865 opened this issue Nov 11, 2024 · 1 comment · May be fixed by #435
Labels
bug Something isn't working

Comments

@lauri865
Copy link

lauri865 commented Nov 11, 2024 •
edited
Loading

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Bringing this to the attention, as it will likely disappear in the void otherwise: https://github.com/orgs/supabase/discussions/30361

How can one implement a custom transport when setupConnection is not run against it from the RealtimeClient?
@lauri865 lauri865 added the bug Something isn't working label Nov 11, 2024
@lauri865 lauri865 changed the title Cannot this.setupConnection() is not called for a custom transport Nov 11, 2024
@lauri865
Copy link
Author

lauri865 commented Nov 11, 2024 •
edited
Loading

We have patched realtime-js on our end and added the missing setupConnection line. Everything seems to be working well.

I presume it's just an oversight/bug, because otherwise one would have to reimplement the whole realtmeclient in order to use a custom transport.

@lauri865 lauri865 linked a pull request Nov 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add setupConnection call to custom transports lauri865/realtime-js
1 participant
@lauri865