This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
Sam/nix2container #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(converted to a draft for the moment until I rework the gh action related to pushing docker image to registry) |
|
actually those docker and other gh actions are not in use yet. I'll make those another PR |
olirice
approved these changes
Feb 22, 2024
This was referenced Feb 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactoring docker image build to use https://github.com/nlewo/nix2container
What is the current behavior?
builtin nixpkgs dockerTools pushes the entire image tar into the nix store, which takes up a huge amount of space
What is the new behavior?
nix2container is smarter about build/rebuild of layers + builds an artifact which describes a container layer with a list of Nix store paths.