Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP client independendent implementation #62

Open
MatiasHiltunen opened this issue Jul 5, 2024 · 1 comment
Open

HTTP client independendent implementation #62

MatiasHiltunen opened this issue Jul 5, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@MatiasHiltunen
Copy link

Feature request

Is your feature request related to a problem? Please describe.

Postgrest is these days primarily used with supabase which default data format is json. Reqwest with features such as json can not be used on the code with the portgrest-rs as adding features to dependency's dependency is not possible if I'm not mistaken.

By not depending solely on reqwest it would allow couple of benefits:

  1. Less dependencies to manage and keep updated
  2. Allows code that use the crate to choose the HTTP client.

Describe the solution you'd like

That would allow usage of the same version of the reqwest as the project that uses this crate with additional features such as reqwest's json.

Preferable way would be to create generic implementation for the whatever http client there is and by that way reduce the amount of same libraries with different versions. For example I had to fork this nice code to only update reqwest and json-feature and use the crate through local lib to be able to use "some_resp.json::()" in my code

Describe alternatives you've considered

Full supabase client implementation with supabase auth would be great alternative

@MatiasHiltunen MatiasHiltunen added the enhancement New feature or request label Jul 5, 2024
@MatiasHiltunen
Copy link
Author

I believe the requested feature is actually redundant as the builder does pretty much the described feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant