New predefined labels are not installed for user when install and upgrade happen in less than 2hours.

[joshelser]

1. Installed v1.19
2. Upgraded to v1.21
3. Observe that Reoccurring Query and Ad Hoc Query labels are missing

call internal.MIGRATE_PREDEFINED_LABELS(7200) called by admin.finalize_setup() does not appear to be properly detecting the new predef'n labels and creating them.

[joshelser]

This is just be a symptom of upgrade testing where the 2hour window to differentiate between "old" and "new" predefined labels is insufficient.

The logic inside call INTERNAL.MIGRATED_PREDEFINED_LABELS(7200) fails when a developer is doing upgrade testing because the time difference between the "old" predefined labels and "new" predefined labels is shorter than the expected 2hour window (7200s).

It may be better to use a sequence number to differentiate "old" from "new" predefined labels and avoid this.