Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AggregationMerkleSumTree to summa-aggregation #172

Closed
enricobottazzi opened this issue Oct 31, 2023 · 1 comment · Fixed by #179
Closed

Add AggregationMerkleSumTree to summa-aggregation #172

enricobottazzi opened this issue Oct 31, 2023 · 1 comment · Fixed by #179
Assignees
@sifnoc
Milestone
V1 improvements a...

Comments

@enricobottazzi
Copy link
Member

enricobottazzi commented Oct 31, 2023 •
edited
Loading

Feature requested as part of "SPECS - "fast and cheap commitment phase".

According to the feature, a CEX should be able to parallelize the building of a set of "mini" Merkle sum trees across different machines and eventually aggregate them into a bigger Merkle Sum Tree.

Although the functionality involving the parallelization will be applied on the backend level, a new data structure AggregationMerkleSumTree is required on the zk-prover level. This has to:

  • Take "mini" Merkle Sum Trees as input and build the AggregationMerkleSumTree
  • generate_proof
  • verify_proof
@enricobottazzi enricobottazzi self-assigned this Oct 31, 2023
@enricobottazzi enricobottazzi changed the title Add feature to build Merkle Sum Tree aggregating a set of "mini" trees Add AggregationTree to zk-prover Nov 1, 2023
@enricobottazzi enricobottazzi changed the title Add AggregationTree to zk-prover Add AggregationMerkleSumTree to zk-prover Nov 1, 2023
@enricobottazzi enricobottazzi moved this to Backlog in ∑ Summa Nov 1, 2023
@enricobottazzi enricobottazzi linked a pull request Nov 1, 2023 that will close this issue
add AggregationTree #177
Closed
@enricobottazzi enricobottazzi mentioned this issue Nov 2, 2023
Closed
@enricobottazzi enricobottazzi moved this from Backlog to Under Review in ∑ Summa Nov 6, 2023
@enricobottazzi enricobottazzi changed the title Add AggregationMerkleSumTree to zk-prover Add AggregationMerkleSumTree to summa-aggregation Nov 6, 2023
@enricobottazzi
Copy link
Member Author

According to the discussion we had today, AggregationTree will be added to aggregation-summa repo implementing the Tree trait.

@sifnoc you can have a look to #177 for the data structure

@enricobottazzi enricobottazzi moved this from Under Review to Backlog in ∑ Summa Nov 6, 2023
@enricobottazzi enricobottazzi removed a link to a pull request Nov 9, 2023
add AggregationTree #177
Closed
@enricobottazzi enricobottazzi linked a pull request Nov 9, 2023 that will close this issue
feat: Tree trait #179
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Merged in ∑ Summa Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sifnoc sifnoc

Labels
None yet
Projects
∑ Summa
Status: Merged
Milestone
V1 improvements and consolidation
Development

Successfully merging a pull request may close this issue.

feat: Tree trait summa-dev/summa-solvency
2 participants
@sifnoc @enricobottazzi