Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private_keys from Signer #154

Closed
enricobottazzi opened this issue Sep 12, 2023 · 0 comments · Fixed by #174
Closed

Remove private_keys from Signer #154

enricobottazzi opened this issue Sep 12, 2023 · 0 comments · Fixed by #174
Assignees

Comments

@enricobottazzi
Copy link
Member

private_keys: &[&str],

Given the latest discussions, I propose removing the support for private_keys from the signer struct as any Exchange interacting with Summa will provide us a file containing the signature data and it's very unlikely that they will use our APIs to perform the signatures.

This modification will also help trimming lines of code and making our backend more lean.

@enricobottazzi enricobottazzi moved this to Backlog in ∑ Summa Nov 1, 2023
@enricobottazzi enricobottazzi moved this from Backlog to Under Review in ∑ Summa Nov 6, 2023
@enricobottazzi enricobottazzi linked a pull request Nov 6, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from Under Review to Merged in ∑ Summa Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged
Development

Successfully merging a pull request may close this issue.

2 participants