Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected behaviour when opening next file in folder if multiple tabs are open #4623

Open
WipeoutMan opened this issue Nov 6, 2024 · 1 comment

Comments

@WipeoutMan
Copy link

WipeoutMan commented Nov 6, 2024

SumatraPDF version

  • Version 3.6.16779 64-bit pre-release

Describe the bug
Unexpected behaviour when opening next file in folder if multiple tabs are open.
The bug happens when using CmdOpenNextFileInFolder / CmdOpenPrevFileInFolder commands (custom shortcut or default key combination).

To Reproduce
1 - Files a.pdf and b.pdf are located in ./Folder1
2 - Files c.pdf and d.pdf are located in ./Folder2
3 - With sumatrapdf closed, open file a.pdf
4 - CmdOpenNextFileInFolder / CmdOpenPrevFileInFolder works as expected
5 - Now open c.pdf (will be the second open tab).
6 - Running CmdOpenNextFileInFolder repeatedly will cycle the second tab: c.pdf > d.pdf > a.pdf > command stops working further.
7 - Running CmdOpenPrevFileInFolder repeatedly in second tab cycles between a/b/c/d files.

Its worth saying that if step 4 is skipped, in step the behaviour of CmdOpenNextFileInFolder is as expected at first for files in folder2 (c/d), but after trying to run the command for the files in folder1 (a/b), the command breaks again for all files.

Bound shortcuts in adv. settings file:
Shortcuts [
[
Cmd = CmdPrevTab
Key = Ctrl + Shift + Tab
ToolbarText = Prev. Tab
]
[
Cmd = CmdNextTab
Key = Ctrl + Tab
ToolbarText = Next Tab
]
[
Cmd = CmdOpenPrevFileInFolder
Key = XButton2
ToolbarText = Prev. File
]
[
Cmd = CmdOpenNextFileInFolder
Key = XButton1
ToolbarText = Next File
]
]

@WipeoutMan WipeoutMan changed the title Unexpected behaviour when opening next file in folder if multiple tabs are open (CmdOpenNextFileInFolder / CmdOpenPrevFileInFolder) Unexpected behaviour when opening next file in folder if multiple tabs are open Nov 6, 2024
@WipeoutMan
Copy link
Author

I'm no coder, but maybe there is some bug in the OpenNextPrevFileInFolder function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant