Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example Router does not follow redirects #86

Open
alexander-schranz opened this issue Apr 12, 2021 · 0 comments
Open

Example Router does not follow redirects #86

alexander-schranz opened this issue Apr 12, 2021 · 0 comments
Labels
bug Error or unexpected behavior of already existing functionality

Comments

@alexander-schranz
Copy link
Member

Currently when we are requesting any url which will be redirected the router.js will not redirect the frontend:

This is the case because fetch is by default following here the redirect and so will return the target data:

return viewDataStore.loadData(location.pathname).then(() => {

The router should do a fetch request without following the redirect and if the response does have a redirect in it it should follow that manually by calling router.goTo(newUrl).

Examples when this is happening:

  • history url, the frontend should here go to the target
  • expired session the frontend should go to the login
@alexander-schranz alexander-schranz added the bug Error or unexpected behavior of already existing functionality label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant