-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cache for the TagFactory #175
Labels
Performance
Problems with performance
Comments
alexander-schranz
added
Performance
Problems with performance
Bug
Error or unexpected behavior of already existing functionality
and removed
Bug
Error or unexpected behavior of already existing functionality
labels
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the TagFactory does always request the Tags here and as the query is based on "name" instead of "ids" doctrine will not use its internal cache for it:
https://github.com/sulu/SuluContentBundle/blob/0.4.0/Content/Infrastructure/Doctrine/TagFactory.php#L45-L50
For performance reasons e.g. imports this is not very good maybe we can introduce simple memory based cache e.g.:
So we can only query the not yet found tags.
Open Question:
The text was updated successfully, but these errors were encountered: