Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report indexing to SDR based on traject writer #1321

Open
thatbudakguy opened this issue Feb 5, 2024 · 1 comment · Fixed by #1366
Open

Report indexing to SDR based on traject writer #1321

thatbudakguy opened this issue Feb 5, 2024 · 1 comment · Fixed by #1366
Assignees
@thatbudakguy
Labels
enhancement New feature or request

Comments

@thatbudakguy
Copy link
Member

thatbudakguy commented Feb 5, 2024 •
edited
Loading

There are cases where the SdrEvents reporter can report that indexing succeeded even if the request to solr didn't happen or failed. In order to avoid that, we should move the call site for the report_indexing_success method into the SolrBetterJsonWriter (maybe by allowing it to accept an optional reporter class/object).

This applies to deletes (report_indexing_deleted) too, since they imply successful communication with solr.
@thatbudakguy thatbudakguy added the enhancement New feature or request label Feb 5, 2024
@thatbudakguy thatbudakguy self-assigned this Feb 5, 2024
@thatbudakguy
Copy link
Member Author

thatbudakguy commented Feb 5, 2024 •
edited
Loading

Alternatively, we could only report when we know something failed. Then we'd never be lying...

@thatbudakguy thatbudakguy removed their assignment Feb 9, 2024
@thatbudakguy thatbudakguy self-assigned this Feb 26, 2024
@thatbudakguy thatbudakguy moved this from Ready to In Progress in Geo Workcycles 2024 Feb 26, 2024
@thatbudakguy thatbudakguy changed the title Report indexing success to SDR based on traject writer Report indexing to SDR based on traject writer Feb 27, 2024
thatbudakguy added a commit that referenced this issue Feb 27, 2024
@thatbudakguy
Shift some indexing reporting to the SolrBetterJsonWriter
6f400ca 
Closes #1321
@thatbudakguy thatbudakguy mentioned this issue Feb 27, 2024
Merged
thatbudakguy added a commit that referenced this issue Feb 29, 2024
@thatbudakguy
Shift some indexing reporting to the SolrBetterJsonWriter
f48aac7 
Closes #1321
@github-project-automation github-project-automation bot moved this from In Progress to Done in Geo Workcycles 2024 Mar 1, 2024
@cbeer cbeer reopened this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thatbudakguy thatbudakguy

Labels
enhancement New feature or request
Projects
Geo Workcycles 2024
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reporting indexing events to SDR based on solr responses sul-dlss/searchworks_traject_indexer
2 participants
@cbeer @thatbudakguy