Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 #71

Open
adambedford opened this issue Oct 5, 2017 · 3 comments
Open

Bootstrap 4 #71

adambedford opened this issue Oct 5, 2017 · 3 comments

Comments

@adambedford
Copy link

Does this addon support Bootstrap 4?

@sukima
Copy link
Owner

sukima commented Oct 7, 2017

I have not done anything to update this addon since Bootstrap 4. I originally tried to copy the old ember {{select}} helper API which brought a lot of issues with it (including two way bindings). Since then ember-power-select has become the de-facto standard for select fields. Because of it's flexibility I can't imagine it being too difficult to use it with Bootstrap 4.

I'd like to deprecate this addon in favor of something like ember-power-select.

@sukima sukima added the wontfix label Oct 7, 2017
@adambedford
Copy link
Author

@sukima Thanks for your note. One of the big reasons I'm interested in this library over ember-power-select, which I use extensively as well, is the handling of multiple selects. ember-power-select approaches multiple selections as tags, whereas ember-cli-select-picker looks more like the bootstrap-select library with a list of items and accompanying check marks. I think there are use cases both approaches -- tags work well for forms and I think this library is good for cases such as table filter controls etc.

I wonder if adding BS4 support could be as simple as removing the bootstrap dependency from bower.json since the markup related to lists and buttons has remained the same (I think).

@sukima
Copy link
Owner

sukima commented Oct 9, 2017

You can give it a try. My only reservation is that I know this repo has a bunch of technical debt. I know you can change the way power-select renders things like tags and make them more like bootstrap pretty easy by giving it your own custom components to use. That way you can render it anyway you like while still keeping the battle tested underlying logic the same.

I just not sure at this point if my addon is worth the technical debt just to get a different template layout.

At some point I would love to get this addon using power-select under the hood but keep the look and feel of Bootstrap. Unfortunately I have to be realistic that I don't have the time to do that refactoring anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants