Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Social links Sidebar and make footer social icons consistent #345

Closed
lakshya-dhariwal opened this issue Jan 5, 2022 · 17 comments
Closed

Comments

@lakshya-dhariwal
Copy link

When you first open the website the social links sidebar ruins the whole website design and seems out of place. We can discuss how to make it look better .

Also the footer social icons are not consistent especially the instagram one.
Also the instagram logo has this purple colour on hover which adds to the inconsistency

Screenshot 2022-01-05 at 6 51 25 PM
Screenshot 2022-01-05 at 6 51 49 PM
Screenshot 2022-01-05 at 6 52 09 PM

@omnaladkar
Copy link

can contribute ?

@srevinsaju
Copy link
Member

srevinsaju commented Jan 10, 2022

Possible Duplicate of #308

@srevinsaju srevinsaju marked this as a duplicate of #308 Jan 10, 2022
@chimosky
Copy link
Member

chimosky commented Jan 10, 2022

Seeing as that's closed, I don't think this is a duplicate anymore.

@quozl
Copy link
Contributor

quozl commented Jan 10, 2022

If it can be fixed easily and simply, do so. Let's put some lipstick on this pig!.

On the other hand, work on this may conflict with #316 so if anyone works on this issue please keep abreast of that issue.

@srevinsaju srevinsaju marked this as not a duplicate of #308 Jan 10, 2022
@lakshya-dhariwal
Copy link
Author

@quozl
So since the site is being shifted to Bootstrap 4 should we fix this issue using bootstrap 4 ( from cdn) as mentioned in #316

@quozl
Copy link
Contributor

quozl commented Jan 12, 2022

@lakshya-dhariwal, please

Thanks!

@nikkuAg
Copy link
Contributor

nikkuAg commented Jan 13, 2022

Can I work on this issue?

@quozl
Copy link
Contributor

quozl commented Jan 14, 2022

First one to get a pull request merged wins. Any number of people can work on an issue.

@nikkuAg
Copy link
Contributor

nikkuAg commented Jan 16, 2022

Hey @quozl,

I want to know which icons are you using like icons from Font Awesome or from some other.

@srevinsaju
Copy link
Member

@nikkuAg reading the README.md, I see

  1. The current website uses customized versions of a few social media icons (service provided by Ion Icons). We do our customizations in a scss file (/css/ion_icon_customization.scss file in our case). Please be careful when updating this file. (Also refer to How to change social media icon colors? the subsection in Answers to few questions section)

@quozl quozl closed this as completed Jan 16, 2022
@quozl quozl reopened this Jan 16, 2022
@quozl
Copy link
Contributor

quozl commented Jan 16, 2022

Oops, keyboard shortcut accidental closure.

@srevinsaju, thanks, I didn't remember that.

@nikkuAg, this is how I learned more;

git grep ionicons
git log css/ion_icon_customization.scss
find | grep ion | grep icon

@nikkuAg nikkuAg mentioned this issue Jan 20, 2022
@nikkuAg
Copy link
Contributor

nikkuAg commented Jan 20, 2022

Hey @quozl @srevinsaju,

Please review the PR I have created.

@Jyoti28Dhikale
Copy link

hey! is this issue still opened?

@quozl
Copy link
Contributor

quozl commented Sep 19, 2022

@Jyoti28Dhikale, thanks for asking. Please review pull request #387.

@Jyoti28Dhikale
Copy link

@quozl Hello! can you please elaborate what should I do in Remove sidebar social media icons #387

@quozl
Copy link
Contributor

quozl commented Sep 21, 2022

Sure. By engaging with Sugar Labs on GitHub, I had presumed you wish to contribute to coding.

Our Guide to Contributing lists the tasks that we think of as contributing to coding. Please read and understand that document, and ask any questions to clarify.

For this particular issue #345 on the web site repository, the next steps are code review, testing, merging, and testing in production. There is a guide for reviewers. Pick an appropriate next step and do it? I do not wish to direct you in detail, because that destroys independence of thought ... I suggest you figure it out from the guide.

@quozl
Copy link
Contributor

quozl commented Feb 3, 2023

Next step is;

  • make the icons a consistent colour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants